Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call

2017-06-04 Thread David Miller 
From: Colin King 
Date: Fri,  2 Jun 2017 16:22:27 +0100

> From: Colin Ian King 
> 
> The proc_remove call is dead code as it occurs after a return and
> hence can never be called. Remove it.
> 
> Detected by CoverityScan, CID#1437743 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King 

Applied.

Re: [PATCH][net-next] rxrpc: remove redundant proc_remove call

2017-06-02 Thread David Howells 
Colin King  wrote:

> From: Colin Ian King 
> 
> The proc_remove call is dead code as it occurs after a return and
> hence can never be called. Remove it.
> 
> Detected by CoverityScan, CID#1437743 ("Logically dead code")
> 
> Signed-off-by: Colin Ian King 

Acked-by: David Howells

[PATCH][net-next] rxrpc: remove redundant proc_remove call

2017-06-02 Thread Colin King 
From: Colin Ian King 

The proc_remove call is dead code as it occurs after a return and
hence can never be called. Remove it.

Detected by CoverityScan, CID#1437743 ("Logically dead code")

Signed-off-by: Colin Ian King 
---
 net/rxrpc/net_ns.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/rxrpc/net_ns.c b/net/rxrpc/net_ns.c
index 26449a6bb076..7edceb8522f5 100644
--- a/net/rxrpc/net_ns.c
+++ b/net/rxrpc/net_ns.c
@@ -59,7 +59,6 @@ static __net_init int rxrpc_init_net(struct net *net)
proc_create("conns", 0444, rxnet->proc_net, _connection_seq_fops);
return 0;
 
-   proc_remove(rxnet->proc_net);
 err_proc:
return ret;
 }
-- 
2.11.0