Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Kok, Auke wrote:
Jeff Garzik wrote:
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c
b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter
*adapter)
if (adapter-hw.mac_type = e1000_82571) {
adapter-have_msi = TRUE;
if ((err = pci_enable_msi(adapter-pdev))) {
-DPRINTK(PROBE, ERR,
+DPRINTK(PROBE, INFO,
Unable to allocate MSI interrupt Error: %d\n, err);
adapter-have_msi = FALSE;
Actually, it should not print any message at all.
pci_enable_msi() failure is a normal event (as you point out). Even
at KERN_INFO level, the message is still misleading.
I've been reworking some of this code and there is even a
pci_disable_msi() missing in case pci_request_irq failed. I'll post a
patch to clean it up in a second.
It seems ixgb needs this too (the message removal at least?)
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Chuck Ebbert wrote:
Kok, Auke wrote:
Jeff Garzik wrote:
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c
b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter
*adapter)
if (adapter-hw.mac_type = e1000_82571) {
adapter-have_msi = TRUE;
if ((err = pci_enable_msi(adapter-pdev))) {
-DPRINTK(PROBE, ERR,
+DPRINTK(PROBE, INFO,
Unable to allocate MSI interrupt Error: %d\n, err);
adapter-have_msi = FALSE;
Actually, it should not print any message at all.
pci_enable_msi() failure is a normal event (as you point out). Even
at KERN_INFO level, the message is still misleading.
I've been reworking some of this code and there is even a
pci_disable_msi() missing in case pci_request_irq failed. I'll post a
patch to clean it up in a second.
It seems ixgb needs this too (the message removal at least?)
yes, I'll get there once I get a chance to get some e1000 work near completion
first. I don't think that for ixgb this is as big of a deal for now. If MSI is
breaking with a 10gig adapter I think people appreciate the error.
We do have to make sure that the PCI subsystem throws errors in the case it is
justified, like when we're out of vectors, or something really bad happens
(perhaps suspend/resumish). I assume that is the case, but I haven't checked.
Cheers,
Auke
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Kok, Auke wrote: for now. If MSI is breaking with a 10gig adapter I think people appreciate the error. No, that is same invalid reasoning discussed earlier in this thread. ixgb needs patching for this problem too. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Jeff Garzik wrote: Kok, Auke wrote: for now. If MSI is breaking with a 10gig adapter I think people appreciate the error. No, that is same invalid reasoning discussed earlier in this thread. ixgb needs patching for this problem too. OK then... A patch that does the exact same for ixgb as I did for e1000 is underway (remove #ifdef CONFIG_PCI_MSI, fix pci_disable_msi leak...). Cheers, Auke - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Jeff Garzik wrote:
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
if (adapter-hw.mac_type = e1000_82571) {
adapter-have_msi = TRUE;
if ((err = pci_enable_msi(adapter-pdev))) {
- DPRINTK(PROBE, ERR,
+ DPRINTK(PROBE, INFO,
Unable to allocate MSI interrupt Error: %d\n, err);
adapter-have_msi = FALSE;
Actually, it should not print any message at all.
pci_enable_msi() failure is a normal event (as you point out). Even at
KERN_INFO level, the message is still misleading.
I've been reworking some of this code and there is even a pci_disable_msi()
missing in case pci_request_irq failed. I'll post a patch to clean it up in a
second.
Cheers,
Auke
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] [e1000] Lower the MSI unavailable message to INFO priority
Currently, if MSI is enabled but unavailable the e1000 prints an error
message Unable to allocate MSI interrupt Error with ERR priority.
This is confusing to users since this is not a functionality error;
the driver will immediately afterwards try to acquire a conventional
PIC/APIC interrupt and will print another message if that fails.
Accordingly, lower the priority of this message to INFO priority, since
it does not reflect any sort of loss of functionality, but rather just a
limitation of the configuration of the runtime system.
Signed-off-by: H. Peter Anvin [EMAIL PROTECTED]
---
drivers/net/e1000/e1000_main.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
if (adapter-hw.mac_type = e1000_82571) {
adapter-have_msi = TRUE;
if ((err = pci_enable_msi(adapter-pdev))) {
- DPRINTK(PROBE, ERR,
+ DPRINTK(PROBE, INFO,
Unable to allocate MSI interrupt Error: %d\n, err);
adapter-have_msi = FALSE;
}
--
1.5.1.4
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] [e1000] Lower the MSI unavailable message to INFO priority
H. Peter Anvin wrote:
diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 637ae8f..089ae3f 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -307,7 +307,7 @@ static int e1000_request_irq(struct e1000_adapter *adapter)
if (adapter-hw.mac_type = e1000_82571) {
adapter-have_msi = TRUE;
if ((err = pci_enable_msi(adapter-pdev))) {
- DPRINTK(PROBE, ERR,
+ DPRINTK(PROBE, INFO,
Unable to allocate MSI interrupt Error: %d\n, err);
adapter-have_msi = FALSE;
Actually, it should not print any message at all.
pci_enable_msi() failure is a normal event (as you point out). Even at
KERN_INFO level, the message is still misleading.
Jeff
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
