[PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread Paul Moore 
A quick patch to change the inet_sock-is_icsk assignment to better fit with
existing kernel coding style.

Signed-off-by: Paul Moore [EMAIL PROTECTED]
Cc: Jarek Poplawski [EMAIL PROTECTED]
Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
 net/ipv4/af_inet.c  |2 +-
 net/ipv6/af_inet6.c |2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Index: net-2.6.20_bugfix_2/net/ipv4/af_inet.c
===
--- net-2.6.20_bugfix_2.orig/net/ipv4/af_inet.c
+++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c
@@ -305,7 +305,7 @@ lookup_protocol:
sk-sk_reuse = 1;
 
inet = inet_sk(sk);
-   inet-is_icsk = (INET_PROTOSW_ICSK  answer_flags) == INET_PROTOSW_ICSK;
+   inet-is_icsk = (INET_PROTOSW_ICSK  answer_flags) != 0;
 
if (SOCK_RAW == sock-type) {
inet-num = protocol;
Index: net-2.6.20_bugfix_2/net/ipv6/af_inet6.c
===
--- net-2.6.20_bugfix_2.orig/net/ipv6/af_inet6.c
+++ net-2.6.20_bugfix_2/net/ipv6/af_inet6.c
@@ -171,7 +171,7 @@ lookup_protocol:
sk-sk_reuse = 1;
 
inet = inet_sk(sk);
-   inet-is_icsk = (INET_PROTOSW_ICSK  answer_flags) == INET_PROTOSW_ICSK;
+   inet-is_icsk = (INET_PROTOSW_ICSK  answer_flags) != 0;
 
if (SOCK_RAW == sock-type) {
inet-num = protocol;

--
paul moore
linux security @ hp

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread Arnaldo Carvalho de Melo 

On 1/9/07, Paul Moore [EMAIL PROTECTED] wrote:

A quick patch to change the inet_sock-is_icsk assignment to better fit with
existing kernel coding style.

Signed-off-by: Paul Moore [EMAIL PROTECTED]
Cc: Jarek Poplawski [EMAIL PROTECTED]
Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED]


Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] INET: style updates for the inet_sock-is_icsk assignment fix

2007-01-09 Thread David Miller 
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Tue, 9 Jan 2007 16:45:12 -0200

 On 1/9/07, Paul Moore [EMAIL PROTECTED] wrote:
  A quick patch to change the inet_sock-is_icsk assignment to better fit with
  existing kernel coding style.
 
  Signed-off-by: Paul Moore [EMAIL PROTECTED]
  Cc: Jarek Poplawski [EMAIL PROTECTED]
  Cc: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
 
 Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]

Ok, the style police win :)
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html