Re: [PATCH] Remove old comments and code in net/ethernet/eth.c

2006-01-06 Thread Kris Katterjohn 
From: David S. Miller
Sent: 1/6/2006 4:08:33 PM
> From: "Kris Katterjohn" <[EMAIL PROTECTED]>
> Date: Fri, 6 Jan 2006 16:05:36 -0800
> 
> > This removes an old comment and old commented-out code that's been there 
> > since
> > at least as far back as 2.4.0.
> > 
> > Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]>
> 
> It's instructive to keep it there so that nobody in the
> future tries to add the "optimization" without understanding
> why it's wrong.

Okay then. That makes sense.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] Remove old comments and code in net/ethernet/eth.c

2006-01-06 Thread Kris Katterjohn 
This removes an old comment and old commented-out code that's been there since
at least as far back as 2.4.0.

Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]>

Thanks!

--- x/net/ethernet/eth.c2006-01-06 12:49:27.0 -0600
+++ y/net/ethernet/eth.c2006-01-06 18:01:43.0 -0600
@@ -168,20 +168,8 @@ __be16 eth_type_trans(struct sk_buff *sk
skb->pkt_type = PACKET_BROADCAST;
else
skb->pkt_type = PACKET_MULTICAST;
-   }
-   
-   /*
-*  This ALLMULTI check should be redundant by 1.4
-*  so don't forget to remove it.
-*
-*  Seems, you forgot to remove it. All silly devices
-*  seems to set IFF_PROMISC.
-*/
-
-   else if(1 /*dev->flags&IFF_PROMISC*/) {
-   if (unlikely(compare_ether_addr(eth->h_dest, dev->dev_addr)))
-   skb->pkt_type = PACKET_OTHERHOST;
-   }
+   } else if (unlikely(compare_ether_addr(eth->h_dest, dev->dev_addr)))
+   skb->pkt_type = PACKET_OTHERHOST;

if (ntohs(eth->h_proto) >= 1536)
return eth->h_proto;


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Remove old comments and code in net/ethernet/eth.c

2006-01-06 Thread David S. Miller 
From: "Kris Katterjohn" <[EMAIL PROTECTED]>
Date: Fri, 6 Jan 2006 16:05:36 -0800

> This removes an old comment and old commented-out code that's been there since
> at least as far back as 2.4.0.
> 
> Signed-off-by: Kris Katterjohn <[EMAIL PROTECTED]>

It's instructive to keep it there so that nobody in the
future tries to add the "optimization" without understanding
why it's wrong.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html