Re: [PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

[Kalle Valo]

Sudip Mukherjee  writes:

> From: Jia-Ju Bai 
>
> The memory allocated by kzalloc in b43_bus_dev_ssb_init and
> b43_bus_dev_bcma_init is not freed.
> This patch fixes the bug by adding kfree in b43_ssb_remove,
> b43_bcma_remove and error handling code of b43_bcma_probe.
>
> Thanks Michael for his suggestion.
>
> Signed-off-by: Jia-Ju Bai 
> Acked-by: Michael Büsch 
> Signed-off-by: Sudip Mukherjee 

If no objections I'm planning to queue this to 4.6-rc2.

-- 
Kalle Valo

[PATCH] b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_init

[Sudip Mukherjee]

From: Jia-Ju Bai 

The memory allocated by kzalloc in b43_bus_dev_ssb_init and
b43_bus_dev_bcma_init is not freed.
This patch fixes the bug by adding kfree in b43_ssb_remove,
b43_bcma_remove and error handling code of b43_bcma_probe.

Thanks Michael for his suggestion.

Signed-off-by: Jia-Ju Bai 
Acked-by: Michael Büsch 
Signed-off-by: Sudip Mukherjee 
---
 drivers/net/wireless/broadcom/b43/main.c | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/b43/main.c 
b/drivers/net/wireless/broadcom/b43/main.c
index 72380af..b0603e7 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -5680,11 +5680,12 @@ static int b43_bcma_probe(struct bcma_device *core)
INIT_WORK(>firmware_load, b43_request_firmware);
schedule_work(>firmware_load);
 
-bcma_out:
return err;
 
 bcma_err_wireless_exit:
ieee80211_free_hw(wl->hw);
+bcma_out:
+   kfree(dev);
return err;
 }
 
@@ -5712,8 +5713,8 @@ static void b43_bcma_remove(struct bcma_device *core)
b43_rng_exit(wl);
 
b43_leds_unregister(wl);
-
ieee80211_free_hw(wl->hw);
+   kfree(wldev->dev);
 }
 
 static struct bcma_driver b43_bcma_driver = {
@@ -5796,6 +5797,7 @@ static void b43_ssb_remove(struct ssb_device *sdev)
 
b43_leds_unregister(wl);
b43_wireless_exit(dev, wl);
+   kfree(dev);
 }
 
 static struct ssb_driver b43_ssb_driver = {
-- 
1.9.1