Re: [PATCH] compat. ifconf: fix limits
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 17:41:16 -0800 > On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: > > > Is this one relevant for -stable? > > Yes, IMO. Have to wait for it to be merged upstream, right? I'll take care of everything, thanks Randy. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] compat. ifconf: fix limits
On Wed, 08 Mar 2006 16:46:27 -0800 (PST) David S. Miller wrote: > From: "Randy.Dunlap" <[EMAIL PROTECTED]> > Date: Wed, 8 Mar 2006 09:16:08 -0800 > > > From: Randy Dunlap <[EMAIL PROTECTED]> > > > > A recent change to compat. dev_ifconf() in fs/compat_ioctl.c > > causes ifconf data to be truncated 1 entry too early when copying it > > to userspace. The correct amount of data (length) is returned, > > but the final entry is empty (zero, not filled in). > > The for-loop 'i' check should use <= to allow the final struct > > ifreq32 to be copied. I also used the ifconf-corruption program > > in kernel bugzilla #4746 to make sure that this change does not > > re-introduce the corruption. > > > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> > > Good catch, applied. Thanks Randy. > > Is this one relevant for -stable? Yes, IMO. Have to wait for it to be merged upstream, right? --- ~Randy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] compat. ifconf: fix limits
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Wed, 8 Mar 2006 09:16:08 -0800 > From: Randy Dunlap <[EMAIL PROTECTED]> > > A recent change to compat. dev_ifconf() in fs/compat_ioctl.c > causes ifconf data to be truncated 1 entry too early when copying it > to userspace. The correct amount of data (length) is returned, > but the final entry is empty (zero, not filled in). > The for-loop 'i' check should use <= to allow the final struct > ifreq32 to be copied. I also used the ifconf-corruption program > in kernel bugzilla #4746 to make sure that this change does not > re-introduce the corruption. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Good catch, applied. Thanks Randy. Is this one relevant for -stable? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
