Re: [PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources()

[David Miller]

From: Geert Uytterhoeven 
Date: Thu, 25 Jun 2015 15:13:29 +0200

> If CONFIG_ACPI=n:
> 
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function 
> ‘xgene_enet_get_resources’:
> drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may 
> be used uninitialized in this function
> 
> If the driver is bound to a legacy platform device, ret will contain
> arbitrary data. If it is non-zero, it will be returned to the caller as
> an error code.
> 
> Signed-off-by: Geert Uytterhoeven 

Applied.
N‹§²ζμrΈ›yϊθšΨb²X¬ΆΗ§vΨ^–)ήΊ{.nΗ+‰·§zΧ^Ύ)ν…
ζθw*jg¬±¨Ά‰šŽŠέ’j/κδzΉή–Šΰ2Šή™¨θ­Ϊ&’)ί‘«aΆΪώψ�G«ιh�ζj:+v‰¨Šwθ†Ω₯

[PATCH] drivers: net: xgene: Pre-initialize ret in xgene_enet_get_resources()

[Geert Uytterhoeven]

If CONFIG_ACPI=n:

drivers/net/ethernet/apm/xgene/xgene_enet_main.c: In function 
‘xgene_enet_get_resources’:
drivers/net/ethernet/apm/xgene/xgene_enet_main.c:951: warning: ‘ret’ may be 
used uninitialized in this function

If the driver is bound to a legacy platform device, ret will contain
arbitrary data. If it is non-zero, it will be returned to the caller as
an error code.

Signed-off-by: Geert Uytterhoeven 
---
 drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c 
b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
index 95153b234c7158c6..299eb4315fe647ba 100644
--- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
+++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c
@@ -948,7 +948,7 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata 
*pdata)
struct resource *res;
void __iomem *base_addr;
u32 offset;
-   int ret;
+   int ret = 0;
 
pdev = pdata->pdev;
dev = &pdev->dev;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html