Re: [PATCH] ip_tunnel: Do not use mark in skb by default

[David Miller]

From: Thomas Winter 
Date: Mon, 26 Feb 2018 10:28:10 +1300

> This reverts commit 5c38bd1b82e1f76f9fa96c1e61c9897cabf1ce45.
> 
> skb->mark contains the mark the encapsulated traffic which
> can result in incorrect routing decisions being made such
> as routing loops if the route chosen is via tunnel itself.
> The correct method should be to use tunnel->fwmark.
> 
> Signed-off-by: Thomas Winter 

Applied, thank you.

[PATCH] ip_tunnel: Do not use mark in skb by default

[Thomas Winter]

This reverts commit 5c38bd1b82e1f76f9fa96c1e61c9897cabf1ce45.

skb->mark contains the mark the encapsulated traffic which
can result in incorrect routing decisions being made such
as routing loops if the route chosen is via tunnel itself.
The correct method should be to use tunnel->fwmark.

Signed-off-by: Thomas Winter 
Cc: "David S. Miller" 
Cc: Alexey Kuznetsov 
Cc: Hideaki YOSHIFUJI 
---
 net/ipv4/ip_tunnel.c | 13 +++--
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c
index d786a8441bce..6d21068f9b55 100644
--- a/net/ipv4/ip_tunnel.c
+++ b/net/ipv4/ip_tunnel.c
@@ -710,16 +710,9 @@ void ip_tunnel_xmit(struct sk_buff *skb, struct net_device 
*dev,
}
}
 
-   if (tunnel->fwmark) {
-   init_tunnel_flow(, protocol, dst, tnl_params->saddr,
-tunnel->parms.o_key, RT_TOS(tos), 
tunnel->parms.link,
-tunnel->fwmark);
-   }
-   else {
-   init_tunnel_flow(, protocol, dst, tnl_params->saddr,
-tunnel->parms.o_key, RT_TOS(tos), 
tunnel->parms.link,
-skb->mark);
-   }
+   init_tunnel_flow(, protocol, dst, tnl_params->saddr,
+tunnel->parms.o_key, RT_TOS(tos), tunnel->parms.link,
+tunnel->fwmark);
 
if (ip_tunnel_encap(skb, tunnel, , ) < 0)
goto tx_error;
-- 
2.16.2