[PATCH] ipvs: Make wrr no available servers error message rate-limited
No available servers is more an error message than something informational. It
should also be rate-limited, else we're going to flood our logs on a busy
director, if all real servers are out of order with a weight of zero.
Signed-off-by: Sven Wegener [EMAIL PROTECTED]
---
Actually, do we need this message at all? The wrr scheduler is the only one
printing an error message in such a case.
net/ipv4/ipvs/ip_vs_wrr.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/ipv4/ipvs/ip_vs_wrr.c b/net/ipv4/ipvs/ip_vs_wrr.c
index 749fa04..85c680a 100644
--- a/net/ipv4/ipvs/ip_vs_wrr.c
+++ b/net/ipv4/ipvs/ip_vs_wrr.c
@@ -22,6 +22,7 @@
#include linux/module.h
#include linux/kernel.h
+#include linux/net.h
#include net/ip_vs.h
@@ -169,7 +170,7 @@ ip_vs_wrr_schedule(struct ip_vs_service *svc, const struct
sk_buff *skb)
*/
if (mark-cw == 0) {
mark-cl = svc-destinations;
- IP_VS_INFO(ip_vs_wrr_schedule():
+ IP_VS_ERR_RL(ip_vs_wrr_schedule():
no available servers\n);
dest = NULL;
goto out;
--
1.5.3.7
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ipvs: Make wrr no available servers error message rate-limited
On Tue, Feb 05, 2008 at 09:30:21PM +0100, Sven Wegener wrote: No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener [EMAIL PROTECTED] Hi Sven, this looks good to me. Acked-by: Simon Horman [EMAIL PROTECTED] --- Actually, do we need this message at all? The wrr scheduler is the only one printing an error message in such a case. I was wondering about that too. Though I'd err on the side of adding it to the other schedulers as neccessary rather than removing it here. But if you'd rather just get rid of it, I have no strong objections. -- Horms -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ipvs: Make wrr no available servers error message rate-limited
From: Simon Horman [EMAIL PROTECTED] Date: Wed, 6 Feb 2008 11:19:09 +0900 On Tue, Feb 05, 2008 at 09:30:21PM +0100, Sven Wegener wrote: No available servers is more an error message than something informational. It should also be rate-limited, else we're going to flood our logs on a busy director, if all real servers are out of order with a weight of zero. Signed-off-by: Sven Wegener [EMAIL PROTECTED] Hi Sven, this looks good to me. Acked-by: Simon Horman [EMAIL PROTECTED] Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
