Re: [PATCH] irda-usb: use NULL instead of 0
From: "Randy.Dunlap" <[EMAIL PROTECTED]> Date: Mon, 1 May 2006 15:31:34 -0700 > Use NULL instead of 0 for a null pointer value (sparse warning): > drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL > pointer > > Correct timeout argument to use milliseconds instead of jiffies. > > Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> Applied, thanks Randy. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] irda-usb: use NULL instead of 0
> I could be mistaken, but wasn't the usb_control_msg timeout type changed in
> kernel 2.6.12?
> The timeout value is no longer in jiffies but in msecs.
ugh, correct. Here's a new patch.
Thanks.
---
From: Randy Dunlap <[EMAIL PROTECTED]>
Use NULL instead of 0 for a null pointer value (sparse warning):
drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL
pointer
Correct timeout argument to use milliseconds instead of jiffies.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/net/irda/irda-usb.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
+++ linux-2617-rc3/drivers/net/irda/irda-usb.c
@@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
if (self->needspatch) {
ret = usb_control_msg (self->usbdev, usb_sndctrlpipe
(self->usbdev, 0),
- 0x02, 0x40, 0, 0, 0, 0,
msecs_to_jiffies(500));
+ 0x02, 0x40, 0, 0, NULL, 0, 500);
if (ret < 0) {
IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
goto err_out_3;
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] irda-usb: use NULL instead of 0
On Tuesday 2 May 2006 00:08, Randy.Dunlap wrote:
> From: Randy Dunlap <[EMAIL PROTECTED]>
>
> Use NULL instead of 0 for a null pointer value (sparse warning):
> drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL
> pointer
>
> Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
> ---
> drivers/net/irda/irda-usb.c |2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
> +++ linux-2617-rc3/drivers/net/irda/irda-usb.c
> @@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
>
> if (self->needspatch) {
> ret = usb_control_msg (self->usbdev, usb_sndctrlpipe
> (self->usbdev, 0),
> -0x02, 0x40, 0, 0, 0, 0,
> msecs_to_jiffies(500));
> +0x02, 0x40, 0, 0, NULL, 0,
> msecs_to_jiffies(500));
I could be mistaken, but wasn't the usb_control_msg timeout type changed in
kernel 2.6.12?
The timeout value is no longer in jiffies but in msecs.
> if (ret < 0) {
> IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
> goto err_out_3;
IvD
pgpPNmsUAxv8r.pgp
Description: PGP signature
[PATCH] irda-usb: use NULL instead of 0
From: Randy Dunlap <[EMAIL PROTECTED]>
Use NULL instead of 0 for a null pointer value (sparse warning):
drivers/net/irda/irda-usb.c:1781:30: warning: Using plain integer as NULL
pointer
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/net/irda/irda-usb.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2617-rc3.orig/drivers/net/irda/irda-usb.c
+++ linux-2617-rc3/drivers/net/irda/irda-usb.c
@@ -1778,7 +1778,7 @@ static int irda_usb_probe(struct usb_int
if (self->needspatch) {
ret = usb_control_msg (self->usbdev, usb_sndctrlpipe
(self->usbdev, 0),
- 0x02, 0x40, 0, 0, 0, 0,
msecs_to_jiffies(500));
+ 0x02, 0x40, 0, 0, NULL, 0,
msecs_to_jiffies(500));
if (ret < 0) {
IRDA_DEBUG (0, "usb_control_msg failed %d\n", ret);
goto err_out_3;
---
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
