[PATCH] mv643xx add missing brackets

2006-11-30 Thread Mariusz Kozlowski 
Hello,

This patch adds missing brackets.

Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]

 include/linux/mv643xx.h |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h  2006-11-16 
05:03:40.0 +0100
+++ linux-2.6.19-rc6-mm2-b/include/linux/mv643xx.h  2006-11-30 
01:10:53.0 +0100
@@ -724,7 +724,7 @@
 #define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG(port) (0x2470 + 
(port10))
 #define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG(port) (0x2474 + 
(port10))
 #define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG(port)(0x247c + 
(port10))
-#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
(port10)
+#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
(port10))
 #define MV643XX_ETH_PORT_DEBUG_0_REG(port) (0x248c + 
(port10))
 #define MV643XX_ETH_PORT_DEBUG_1_REG(port) (0x2490 + 
(port10))
 #define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG(port) (0x2494 + 
(port10))
@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (119)
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (120)
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((120) | (119))
-#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((121)
+#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((121))
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_5 ((121) | (119))
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_6 ((121) | (120))
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_7 ((121) | (120) | (119))


-- 
Regards,

Mariusz Kozlowski
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mv643xx add missing brackets

2006-11-30 Thread Dale Farnsworth 
On Thu, Nov 30, 2006 at 10:35:37AM +0100, Mariusz Kozlowski wrote:
 Hello,
 
   This patch adds missing brackets.
 
 Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]
 
  include/linux/mv643xx.h |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
 
 --- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h2006-11-16 
 05:03:40.0 +0100
 +++ linux-2.6.19-rc6-mm2-b/include/linux/mv643xx.h2006-11-30 
 01:10:53.0 +0100
 @@ -724,7 +724,7 @@
  #define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG(port) (0x2470 + 
 (port10))
  #define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG(port) (0x2474 + 
 (port10))
  #define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG(port)(0x247c + 
 (port10))
 -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
 (port10)
 +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
 (port10))

Good.  Thanks.

  #define MV643XX_ETH_PORT_DEBUG_0_REG(port) (0x248c + 
 (port10))
  #define MV643XX_ETH_PORT_DEBUG_1_REG(port) (0x2490 + 
 (port10))
  #define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG(port) (0x2494 + 
 (port10))
 @@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {
  #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1   (119)
  #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2   (120)
  #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3   ((120) | (119))
 -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4   ((121)
 +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4   ((121))

Mariusz, please remove the extra parenthesis instead of adding
an extra one, like:
#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4  (121)
and resubmit.

Thanks,
-Dale
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mv643xx add missing brackets

2006-11-30 Thread Mariusz Kozlowski 
  +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((121))
 
 Mariusz, please remove the extra parenthesis instead of adding
 an extra one, like:
   #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4  (121)
 and resubmit.

Sure. Here it goes. Second try:

This patch fixes some mv643xx macros.

Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]

 include/linux/mv643xx.h |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.19-rc6-mm2-a/include/linux/mv643xx.h  2006-11-16 
05:03:40.0 +0100
+++ linux-2.6.19-rc6-mm2-b/include/linux/mv643xx.h  2006-11-30 
11:30:14.0 +0100
@@ -724,7 +724,7 @@
 #define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG(port) (0x2470 + 
(port10))
 #define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG(port) (0x2474 + 
(port10))
 #define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG(port)(0x247c + 
(port10))
-#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
(port10)
+#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER(port)  (0x2484 + 
(port10))
 #define MV643XX_ETH_PORT_DEBUG_0_REG(port) (0x248c + 
(port10))
 #define MV643XX_ETH_PORT_DEBUG_1_REG(port) (0x2490 + 
(port10))
 #define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG(port) (0x2494 + 
(port10))
@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (119)
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (120)
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((120) | (119))
-#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((121)
+#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (121)
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_5 ((121) | (119))
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_6 ((121) | (120))
 #define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_7 ((121) | (120) | (119))


-- 
Regards,

Mariusz Kozlowski
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html