Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
Josh Boyer wrote: On Wed, 6 Feb 2008 13:21:59 +0100 Stefan Roese [EMAIL PROTECTED] wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Acked-by: Josh Boyer [EMAIL PROTECTED] upon further reflection, ACK, take this via ppc tree -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
Josh Boyer wrote: On Thu, 31 Jan 2008 10:14:58 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] I need to test if it works on CAB, can't change the DT on those. I'll let you know tomorrow. This should be fine on CAB. The rgmii node has: compatible = ibm,rgmii-axon, ibm,rgmii so the match should still catch on the latter. How about this patch? Ben, if you think this is ok then we should make sure that it goes in in this merge-window, since the other dts patch relies on it. It's fine. Jeff, any chance this can get into .25 soon? I have another patch queued up behind this one that requires it, and I don't see it in any of your trees or branches. Or, if you aren't opposed, I can take it through Paul's tree with your Ack. can you resend? I don't see it in the pile -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
With the removal the the rgmii-interface device_type property from the
dts files, the newemac driver needs an update to only rely on compatible
property.
Signed-off-by: Stefan Roese [EMAIL PROTECTED]
Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED]
---
drivers/net/ibm_newemac/rgmii.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c
index 9bc1132..5757788 100644
--- a/drivers/net/ibm_newemac/rgmii.c
+++ b/drivers/net/ibm_newemac/rgmii.c
@@ -302,7 +302,6 @@ static int __devexit rgmii_remove(struct of_device *ofdev)
static struct of_device_id rgmii_match[] =
{
{
- .type = rgmii-interface,
.compatible = ibm,rgmii,
},
{
--
1.5.4.rc3
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wednesday 06 February 2008, Jeff Garzik wrote: Jeff, any chance this can get into .25 soon? I have another patch queued up behind this one that requires it, and I don't see it in any of your trees or branches. Or, if you aren't opposed, I can take it through Paul's tree with your Ack. can you resend? I don't see it in the pile Will do. Best regards, Stefan -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 6 Feb 2008 13:21:59 +0100 Stefan Roese [EMAIL PROTECTED] wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Acked-by: Josh Boyer [EMAIL PROTECTED] josh -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. What about systems using an older dts, such as one kexec:ing from an older kernel? Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility. -Olof -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson [EMAIL PROTECTED] wrote: On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. What about systems using an older dts, such as one kexec:ing from an older kernel? Like what? Kexec doesn't work on 4xx yet. Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility. We checked Axon, which is the only non-DTS machine that uses EMAC and it will work fine with this change. josh -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, Feb 06, 2008 at 10:23:40AM -0600, Josh Boyer wrote: On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson [EMAIL PROTECTED] wrote: On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. What about systems using an older dts, such as one kexec:ing from an older kernel? Like what? Kexec doesn't work on 4xx yet. Sure, but similar restrictions would apply for customers who have a flashed device tree that want to boot a newer kernel. Deprecating old device tree support is something that should be done very carefully. Just because the device tree source is distributed in the kernel tree doesn't mean it can give up backwards compatibility. We checked Axon, which is the only non-DTS machine that uses EMAC and it will work fine with this change. Ah, ok. I remember discussions about this patch before then, sounds like it's safe. I just triggered on the dts-centric patch description. Objections withdrawn. :) -Olof -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 2008-02-06 at 10:35 -0600, Olof Johansson wrote: On Wed, Feb 06, 2008 at 10:23:40AM -0600, Josh Boyer wrote: On Wed, 6 Feb 2008 10:01:57 -0600 Olof Johansson [EMAIL PROTECTED] wrote: On Wed, Feb 06, 2008 at 01:21:59PM +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. What about systems using an older dts, such as one kexec:ing from an older kernel? Like what? Kexec doesn't work on 4xx yet. Sure, but similar restrictions would apply for customers who have a flashed device tree that want to boot a newer kernel. Deprecating old device tree support is something that should be done very carefully. In that case, we -know- there was no such thing as the proper support for 4xx in powerpc isn't really there before 2.6.25 anyway. The only other is Cell/Axon which we verified still works. Ben. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Thu, 31 Jan 2008 10:14:58 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] I need to test if it works on CAB, can't change the DT on those. I'll let you know tomorrow. This should be fine on CAB. The rgmii node has: compatible = ibm,rgmii-axon, ibm,rgmii so the match should still catch on the latter. How about this patch? Ben, if you think this is ok then we should make sure that it goes in in this merge-window, since the other dts patch relies on it. It's fine. Jeff, any chance this can get into .25 soon? I have another patch queued up behind this one that requires it, and I don't see it in any of your trees or branches. Or, if you aren't opposed, I can take it through Paul's tree with your Ack. josh -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
Jeff, any chance this can get into .25 soon? I have another patch queued up behind this one that requires it, and I don't see it in any of your trees or branches. Or, if you aren't opposed, I can take it through Paul's tree with your Ack. In case my it's fine wasn't enough, here's an: Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 2008-01-30 at 07:16 +0100, Stefan Roese wrote: On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] I need to test if it works on CAB, can't change the DT on those. I'll let you know tomorrow. This should be fine on CAB. The rgmii node has: compatible = ibm,rgmii-axon, ibm,rgmii so the match should still catch on the latter. How about this patch? Ben, if you think this is ok then we should make sure that it goes in in this merge-window, since the other dts patch relies on it. It's fine. Ben. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wednesday 16 January 2008, Josh Boyer wrote: On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] I need to test if it works on CAB, can't change the DT on those. I'll let you know tomorrow. This should be fine on CAB. The rgmii node has: compatible = ibm,rgmii-axon, ibm,rgmii so the match should still catch on the latter. How about this patch? Ben, if you think this is ok then we should make sure that it goes in in this merge-window, since the other dts patch relies on it. Thanks. Best regards, Stefan -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote:
With the removal the the rgmii-interface device_type property from the
dts files, the newemac driver needs an update to only rely on compatible
property.
Signed-off-by: Stefan Roese [EMAIL PROTECTED]
---
Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED]
Jeff, please stick that into your queue for 2.6.25, thanks !
Ben.
drivers/net/ibm_newemac/rgmii.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c
index 9bc1132..5757788 100644
--- a/drivers/net/ibm_newemac/rgmii.c
+++ b/drivers/net/ibm_newemac/rgmii.c
@@ -302,7 +302,6 @@ static int __devexit rgmii_remove(struct of_device *ofdev)
static struct of_device_id rgmii_match[] =
{
{
- .type = rgmii-interface,
.compatible = ibm,rgmii,
},
{
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
With the removal the the rgmii-interface device_type property from the
dts files, the newemac driver needs an update to only rely on compatible
property.
Signed-off-by: Stefan Roese [EMAIL PROTECTED]
---
drivers/net/ibm_newemac/rgmii.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c
index 9bc1132..5757788 100644
--- a/drivers/net/ibm_newemac/rgmii.c
+++ b/drivers/net/ibm_newemac/rgmii.c
@@ -302,7 +302,6 @@ static int __devexit rgmii_remove(struct of_device *ofdev)
static struct of_device_id rgmii_match[] =
{
{
- .type = rgmii-interface,
.compatible = ibm,rgmii,
},
{
--
1.5.4.rc3
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, Jan 16, 2008 at 10:37:10AM +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. In fact, this patch should go in before the one changing the dts files. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote:
With the removal the the rgmii-interface device_type property from the
dts files, the newemac driver needs an update to only rely on compatible
property.
Signed-off-by: Stefan Roese [EMAIL PROTECTED]
I need to test if it works on CAB, can't change the DT on those. I'll
let you know tomorrow.
---
drivers/net/ibm_newemac/rgmii.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c
index 9bc1132..5757788 100644
--- a/drivers/net/ibm_newemac/rgmii.c
+++ b/drivers/net/ibm_newemac/rgmii.c
@@ -302,7 +302,6 @@ static int __devexit rgmii_remove(struct of_device *ofdev)
static struct of_device_id rgmii_match[] =
{
{
- .type = rgmii-interface,
.compatible = ibm,rgmii,
},
{
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] net: NEWEMAC: Remove rgmii-interface from rgmii matching table
On Wed, 16 Jan 2008 20:53:59 +1100 Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Wed, 2008-01-16 at 10:37 +0100, Stefan Roese wrote: With the removal the the rgmii-interface device_type property from the dts files, the newemac driver needs an update to only rely on compatible property. Signed-off-by: Stefan Roese [EMAIL PROTECTED] I need to test if it works on CAB, can't change the DT on those. I'll let you know tomorrow. This should be fine on CAB. The rgmii node has: compatible = ibm,rgmii-axon, ibm,rgmii so the match should still catch on the latter. josh -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
