Re: [PATCH] net: ena: change the return type of ena_set_push_mode() to be void.

[David Miller]

From: Rami Rosen 
Date: Tue, 23 Aug 2016 20:20:17 +0300

> This patch changes the return type of ena_set_push_mode() to be void,
> as it always returns 0.
> 
> Signed-off-by: Rami Rosen 

Applied, thanks.

[PATCH] net: ena: change the return type of ena_set_push_mode() to be void.

[Rami Rosen]

This patch changes the return type of ena_set_push_mode() to be void,
as it always returns 0.

Signed-off-by: Rami Rosen 
---
 drivers/net/ethernet/amazon/ena/ena_netdev.c | 12 +++-
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c 
b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 5c536b8..bfeaec5 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2681,8 +2681,8 @@ static int ena_calc_io_queue_num(struct pci_dev *pdev,
return io_queue_num;
 }
 
-static int ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev,
-struct ena_com_dev_get_features_ctx *get_feat_ctx)
+static void ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev 
*ena_dev,
+ struct ena_com_dev_get_features_ctx *get_feat_ctx)
 {
bool has_mem_bar;
 
@@ -2693,8 +2693,6 @@ static int ena_set_push_mode(struct pci_dev *pdev, struct 
ena_com_dev *ena_dev,
ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV;
else
ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST;
-
-   return 0;
 }
 
 static void ena_set_dev_offloads(struct ena_com_dev_get_features_ctx *feat,
@@ -2913,11 +2911,7 @@ static int ena_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
goto err_free_region;
}
 
-   rc = ena_set_push_mode(pdev, ena_dev, _feat_ctx);
-   if (rc) {
-   dev_err(>dev, "Invalid module param(push_mode)\n");
-   goto err_device_destroy;
-   }
+   ena_set_push_mode(pdev, ena_dev, _feat_ctx);
 
if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) {
ena_dev->mem_bar = ioremap_wc(pci_resource_start(pdev, 
ENA_MEM_BAR),
-- 
2.7.4