Re: [PATCH] netfilter: ipt_CLUSTERIP: fix build error without procfs

[Pablo Neira Ayuso]

On Fri, Jan 13, 2017 at 04:41:03PM +0100, Arnd Bergmann wrote:
> We can't access c->pde if CONFIG_PROC_FS is disabled:
> 
> net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_config_find_get':
> net/ipv4/netfilter/ipt_CLUSTERIP.c:147:9: error: 'struct clusterip_config' 
> has no member named 'pde'
> 
> This moves the check inside of another #ifdef.
> 
> Fixes: 6c5d5cfbe3c5 ("netfilter: ipt_CLUSTERIP: check duplicate config when 
> initializing")
> Signed-off-by: Arnd Bergmann 

Applied, thanks Arnd.

[PATCH] netfilter: ipt_CLUSTERIP: fix build error without procfs

[Arnd Bergmann]

We can't access c->pde if CONFIG_PROC_FS is disabled:

net/ipv4/netfilter/ipt_CLUSTERIP.c: In function 'clusterip_config_find_get':
net/ipv4/netfilter/ipt_CLUSTERIP.c:147:9: error: 'struct clusterip_config' has 
no member named 'pde'

This moves the check inside of another #ifdef.

Fixes: 6c5d5cfbe3c5 ("netfilter: ipt_CLUSTERIP: check duplicate config when 
initializing")
Signed-off-by: Arnd Bergmann 
---
 net/ipv4/netfilter/ipt_CLUSTERIP.c | 7 ++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/ipv4/netfilter/ipt_CLUSTERIP.c 
b/net/ipv4/netfilter/ipt_CLUSTERIP.c
index 1e38d8bf5631..52f26459efc3 100644
--- a/net/ipv4/netfilter/ipt_CLUSTERIP.c
+++ b/net/ipv4/netfilter/ipt_CLUSTERIP.c
@@ -144,7 +144,12 @@ clusterip_config_find_get(struct net *net, __be32 
clusterip, int entry)
rcu_read_lock_bh();
c = __clusterip_config_find(net, clusterip);
if (c) {
-   if (!c->pde || unlikely(!atomic_inc_not_zero(>refcount)))
+#ifdef CONFIG_PROC_FS
+   if (!c->pde)
+   c = NULL;
+   else
+#endif
+   if (unlikely(!atomic_inc_not_zero(>refcount)))
c = NULL;
else if (entry)
atomic_inc(>entries);
-- 
2.9.0