Re: [PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Tue, 18 Jul 2017 15:45:29 -0500

> Remove unnecessary static on local variable fw_dump_ops.
> Such variable is initialized before being used, on every
> execution path throughout the function. The static has no
> benefit and, removing it reduces the object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
 ...
> Signed-off-by: Gustavo A. R. Silva 

Applied.

[PATCH] qlcnic: remove unnecessary static in qlcnic_dump_fw()

[Gustavo A. R. Silva]

Remove unnecessary static on local variable fw_dump_ops.
Such variable is initialized before being used, on every
execution path throughout the function. The static has no
benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
 when strict
?x = e;

In the following log you can see a difference in the object file size.
This log is the output of the size command, before and after the code
change:

before:
   textdata bss dec hex filename
  190322136  64   2123252f0 
drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o

after:
   textdata bss dec hex filename
  190202048   0   21068524c 
drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.o

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c 
b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
index 0844b7c..afa10a1 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_minidump.c
@@ -1285,7 +1285,7 @@ int qlcnic_fw_cmd_get_minidump_temp(struct qlcnic_adapter 
*adapter)
 int qlcnic_dump_fw(struct qlcnic_adapter *adapter)
 {
struct qlcnic_fw_dump *fw_dump = >ahw->fw_dump;
-   static const struct qlcnic_dump_operations *fw_dump_ops;
+   const struct qlcnic_dump_operations *fw_dump_ops;
struct qlcnic_83xx_dump_template_hdr *hdr_83xx;
u32 entry_offset, dump, no_entries, buf_offset = 0;
int i, k, ops_cnt, ops_index, dump_size = 0;
-- 
2.5.0