Re: [PATCH] sh_eth: simplify sh_eth_check_reset()

[David Miller]

From: Sergei Shtylyov 
Date: Sun, 18 Feb 2018 18:21:05 +0300

> The *while* loop in this function  can be turned into a normal *for* loop.
> And getting rid  of the  single return point saves us a few more LoCs...
> 
> Signed-off-by: Sergei Shtylyov 

Applied to net-next, thanks Sergei.

> The patch is against DaveM's 'net-next.git' repo.

It is actually easier for you (and me) if you just indicate this in
your Subject like "[PATCH net-next]" in the future.

Thank you.

Re: [PATCH] sh_eth: simplify sh_eth_check_reset()

[Geert Uytterhoeven]

On Sun, Feb 18, 2018 at 4:21 PM, Sergei Shtylyov
 wrote:
> The *while* loop in this function  can be turned into a normal *for* loop.
> And getting rid  of the  single return point saves us a few more LoCs...
>
> Signed-off-by: Sergei Shtylyov 

Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH] sh_eth: simplify sh_eth_check_reset()

[Sergei Shtylyov]

The *while* loop in this function  can be turned into a normal *for* loop.
And getting rid  of the  single return point saves us a few more LoCs...

Signed-off-by: Sergei Shtylyov 

---
The patch is against DaveM's 'net-next.git' repo.

 drivers/net/ethernet/renesas/sh_eth.c |   16 ++--
 1 file changed, 6 insertions(+), 10 deletions(-)

Index: net-next/drivers/net/ethernet/renesas/sh_eth.c
===
--- net-next.orig/drivers/net/ethernet/renesas/sh_eth.c
+++ net-next/drivers/net/ethernet/renesas/sh_eth.c
@@ -962,20 +962,16 @@ static void sh_eth_set_default_cpu_data(
 
 static int sh_eth_check_reset(struct net_device *ndev)
 {
-   int ret = 0;
-   int cnt = 100;
+   int cnt;
 
-   while (cnt > 0) {
+   for (cnt = 100; cnt > 0; cnt--) {
if (!(sh_eth_read(ndev, EDMR) & EDMR_SRST_GETHER))
-   break;
+   return 0;
mdelay(1);
-   cnt--;
}
-   if (cnt <= 0) {
-   netdev_err(ndev, "Device reset failed\n");
-   ret = -ETIMEDOUT;
-   }
-   return ret;
+
+   netdev_err(ndev, "Device reset failed\n");
+   return -ETIMEDOUT;
 }
 
 static int sh_eth_reset(struct net_device *ndev)