[PATCH] ssb: mark ssb_bus_register as __maybe_unused

[Arnd Bergmann]

The SoC variant of the ssb code is now optional like the other
ones, which means we can build the framwork without any
front-end, but that results in a warning:

drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used 
[-Wunused-function]

This annotates the ssb_bus_register function as __maybe_unused to
shut up the warning. A configuration like this will not work on
any hardware of course, but we still want this to silently build
without warnings if the configuration is allowed in the first
place.

Signed-off-by: Arnd Bergmann 
Fixes: 845da6e58e19 ("ssb: add Kconfig entry for compiling SoC related code")

This showed up on ARM at91_defconfig and sama5_defconfig, so we should probably
change those configurations as well. I can't see why they enable CONFIG_SSB
when they do not use any drivers for this framework.

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 5d1e9a0fc389..e2ff6b5b2094 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -613,9 +613,10 @@ out:
return err;
 }
 
-static int ssb_bus_register(struct ssb_bus *bus,
-   ssb_invariants_func_t get_invariants,
-   unsigned long baseaddr)
+static int __maybe_unused
+ssb_bus_register(struct ssb_bus *bus,
+ssb_invariants_func_t get_invariants,
+unsigned long baseaddr)
 {
int err;
 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

[Michael Büsch]

On Tue, 03 Nov 2015 16:05:51 +0100
Arnd Bergmann  wrote:

> The SoC variant of the ssb code is now optional like the other
> ones, which means we can build the framwork without any
> front-end, but that results in a warning:
> 
> drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used 
> [-Wunused-function]
> 
> This annotates the ssb_bus_register function as __maybe_unused to
> shut up the warning. A configuration like this will not work on
> any hardware of course, but we still want this to silently build
> without warnings if the configuration is allowed in the first
> place.


Is there a simple way to disallow this configuration?

-- 
Michael


pgpwqvJa74ya6.pgp
Description: OpenPGP digital signature

Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

[Arnd Bergmann]

On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> On Tue, 03 Nov 2015 16:05:51 +0100
> Arnd Bergmann  wrote:
> 
> > The SoC variant of the ssb code is now optional like the other
> > ones, which means we can build the framwork without any
> > front-end, but that results in a warning:
> > 
> > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not used 
> > [-Wunused-function]
> > 
> > This annotates the ssb_bus_register function as __maybe_unused to
> > shut up the warning. A configuration like this will not work on
> > any hardware of course, but we still want this to silently build
> > without warnings if the configuration is allowed in the first
> > place.
> 
> 
> Is there a simple way to disallow this configuration?

I could not come up with a simple one. We could turn 'CONFIG_SSB' into
a silent option and have it selected by each bus specific driver,
but then we also have to change all the device drivers (usb and
wireless I guess) to use 'depends on' rather than 'select'.

Arnd
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ssb: mark ssb_bus_register as __maybe_unused

[Michael Büsch]

On Tue, 03 Nov 2015 17:42:26 +0100
Arnd Bergmann  wrote:

> On Tuesday 03 November 2015 17:27:21 Michael Büsch wrote:
> > On Tue, 03 Nov 2015 16:05:51 +0100
> > Arnd Bergmann  wrote:
> >   
> > > The SoC variant of the ssb code is now optional like the other
> > > ones, which means we can build the framwork without any
> > > front-end, but that results in a warning:
> > > 
> > > drivers/ssb/main.c:616:12: warning: 'ssb_bus_register' defined but not 
> > > used [-Wunused-function]
> > > 
> > > This annotates the ssb_bus_register function as __maybe_unused to
> > > shut up the warning. A configuration like this will not work on
> > > any hardware of course, but we still want this to silently build
> > > without warnings if the configuration is allowed in the first
> > > place.  
> > 
> > 
> > Is there a simple way to disallow this configuration?  
> 
> I could not come up with a simple one. We could turn 'CONFIG_SSB' into
> a silent option and have it selected by each bus specific driver,
> but then we also have to change all the device drivers (usb and
> wireless I guess) to use 'depends on' rather than 'select'.

The other way around?
The drivers already select SSB. However I think we should have SSB
selectable by user for the embedded case.

But well, I can live with this patch then. Kalle, you might apply it
with

Acked-by: Michael Buesch 

-- 
Michael


pgpmuggch9Wzm.pgp
Description: OpenPGP digital signature