Re: [PATCH] tcp-lp: prevent chance for oops
oic i learn it and will change it in coming on version On 9/30/06, David Miller [EMAIL PROTECTED] wrote: From: Wong Edison [EMAIL PROTECTED] Date: Sat, 30 Sep 2006 03:27:00 +0800 I do this since i have a sourceforge homepage for it. I update the CVS version there, test, and then submit to netdev. As I sync code in both side, this $Id$ is keeped. May you just let it be? I think it will let my maintenance become more simple... You could not even generate a clean patch to me, it just gets in the way and causes more work for me and anyone else who tries to use your patches. If you want to use versioning, use MODULE_VERSION() just like everyone else in the kernel does. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp-lp: prevent chance for oops
I do this since i have a sourceforge homepage for it. I update the CVS version there, test, and then submit to netdev. As I sync code in both side, this $Id$ is keeped. May you just let it be? I think it will let my maintenance become more simple... On 9/29/06, David Miller [EMAIL PROTECTED] wrote: From: Wong Edison [EMAIL PROTECTED] Date: Thu, 28 Sep 2006 18:43:58 +0800 * - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $ + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $ BTW, I'm deleting this line from the source file in the tree because every patch you send doesn't apply cleanly because your patch is against a different string on this line and we don't use $Id$ tags in the kernel sources anyways. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp-lp: prevent chance for oops
From: Wong Edison [EMAIL PROTECTED] Date: Sat, 30 Sep 2006 03:27:00 +0800 I do this since i have a sourceforge homepage for it. I update the CVS version there, test, and then submit to netdev. As I sync code in both side, this $Id$ is keeped. May you just let it be? I think it will let my maintenance become more simple... You could not even generate a clean patch to me, it just gets in the way and causes more work for me and anyone else who tries to use your patches. If you want to use versioning, use MODULE_VERSION() just like everyone else in the kernel does. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH] tcp-lp: prevent chance for oops
This patch fix the chance for tcp_lp_remote_hz_estimator return 0, if 0 rhz 64. It also make sure the flag LP_VALID_RHZ is set correctly. Signed-off-by: Wong Hoi Sing Edison [EMAIL PROTECTED] --- diff -urpN linux-2.6.18/net/ipv4/tcp_lp.c linux/net/ipv4/tcp_lp.c --- linux-2.6.18/net/ipv4/tcp_lp.c 2006-09-20 11:42:06.0 +0800 +++ linux/net/ipv4/tcp_lp.c 2006-09-28 18:30:17.0 +0800 @@ -32,7 +32,7 @@ * SourceForge project page: * http://tcp-lp-mod.sourceforge.net/ * - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $ + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $ */ #include linux/config.h @@ -165,7 +165,7 @@ static u32 tcp_lp_remote_hz_estimator(st out: /* record time for successful remote HZ calc */ - if (rhz 0) + if ((rhz 6) 0) lp-flag |= LP_VALID_RHZ; else lp-flag = ~LP_VALID_RHZ; - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp-lp: prevent chance for oops
From: Wong Edison [EMAIL PROTECTED] Date: Thu, 28 Sep 2006 18:43:58 +0800 This patch fix the chance for tcp_lp_remote_hz_estimator return 0, if 0 rhz 64. It also make sure the flag LP_VALID_RHZ is set correctly. Signed-off-by: Wong Hoi Sing Edison [EMAIL PROTECTED] Applied, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] tcp-lp: prevent chance for oops
From: Wong Edison [EMAIL PROTECTED] Date: Thu, 28 Sep 2006 18:43:58 +0800 * - * Version: $Id: tcp_lp.c,v 1.24 2006/09/05 20:22:53 hswong3i Exp $ + * Version: $Id: tcp_lp.c,v 1.25 2006/09/22 20:50:27 hswong3i Exp $ BTW, I'm deleting this line from the source file in the tree because every patch you send doesn't apply cleanly because your patch is against a different string on this line and we don't use $Id$ tags in the kernel sources anyways. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
