Re: [PATCH] tools/libbpf: Avoid possibly using uninitialized variable

[Daniel Borkmann]

On 02/20/2018 02:00 AM, Jeremy Cline wrote:
> Fixes a GCC maybe-uninitialized warning introduced by 48cca7e44f9f.
> "text" is only initialized inside the if statement so only print debug
> info there.
> 
> Signed-off-by: Jeremy Cline 

Looks good, applied to bpf tree, thanks Jeremy!

[PATCH] tools/libbpf: Avoid possibly using uninitialized variable

[Jeremy Cline]

Fixes a GCC maybe-uninitialized warning introduced by 48cca7e44f9f.
"text" is only initialized inside the if statement so only print debug
info there.

Signed-off-by: Jeremy Cline 
---
 tools/lib/bpf/libbpf.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 97073d649c1a..5bbbf285af74 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -1060,11 +1060,12 @@ bpf_program__reloc_text(struct bpf_program *prog, 
struct bpf_object *obj,
prog->insns = new_insn;
prog->main_prog_cnt = prog->insns_cnt;
prog->insns_cnt = new_cnt;
+   pr_debug("added %zd insn from %s to prog %s\n",
+text->insns_cnt, text->section_name,
+prog->section_name);
}
insn = >insns[relo->insn_idx];
insn->imm += prog->main_prog_cnt - relo->insn_idx;
-   pr_debug("added %zd insn from %s to prog %s\n",
-text->insns_cnt, text->section_name, prog->section_name);
return 0;
 }
 
-- 
2.16.2