Re: [PATCH] vhost/vsock: Remove unused but set variable

2016-12-14 Thread Michael S. Tsirkin 
On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser 

doesn't apply anymore.

> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
> index e3b30ea9ece5..9c3c68b9a49e 100644
> --- a/drivers/vhost/vsock.c
> +++ b/drivers/vhost/vsock.c
> @@ -195,7 +195,6 @@ static int
>  vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>  {
>   struct vhost_vsock *vsock;
> - struct vhost_virtqueue *vq;
>   int len = pkt->len;
>  
>   /* Find the vhost_vsock according to guest context id  */
> @@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
>   return -ENODEV;
>   }
>  
> - vq = >vqs[VSOCK_VQ_RX];
> -
>   if (pkt->reply)
>   atomic_inc(>queued_replies);
>  
> -- 
> 2.11.0.rc0.7.gbe5a750
>

Re: [PATCH] vhost/vsock: Remove unused but set variable

2016-11-15 Thread Stefan Hajnoczi 
On Fri, Nov 11, 2016 at 02:26:31PM +0100, Tobias Klauser wrote:
> Remove the unused but set variable vq in vhost_transport_send_pkt() to
> fix the following GCC warning when building with 'W=1':
> 
>   drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used
> 
> Signed-off-by: Tobias Klauser 
> ---
>  drivers/vhost/vsock.c | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Stefan Hajnoczi 


signature.asc
Description: PGP signature

[PATCH] vhost/vsock: Remove unused but set variable

2016-11-11 Thread Tobias Klauser 
Remove the unused but set variable vq in vhost_transport_send_pkt() to
fix the following GCC warning when building with 'W=1':

  drivers/vhost/vsock.c:198:26: warning: variable ‘vq’ set but not used

Signed-off-by: Tobias Klauser 
---
 drivers/vhost/vsock.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index e3b30ea9ece5..9c3c68b9a49e 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -195,7 +195,6 @@ static int
 vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
 {
struct vhost_vsock *vsock;
-   struct vhost_virtqueue *vq;
int len = pkt->len;
 
/* Find the vhost_vsock according to guest context id  */
@@ -205,8 +204,6 @@ vhost_transport_send_pkt(struct virtio_vsock_pkt *pkt)
return -ENODEV;
}
 
-   vq = >vqs[VSOCK_VQ_RX];
-
if (pkt->reply)
atomic_inc(>queued_replies);
 
-- 
2.11.0.rc0.7.gbe5a750