Re: [PATCH] vortex_up should initialize err

2007-10-18 Thread Steffen Klassert 
On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
 Badari Pulavarty wrote:
 Simple compile warning fix. (against 2.6.23-git12)
 
 Thanks,
 Badari
 
 vortex_up() should initialize 'err' for a successful return.
 
 drivers/net/3c59x.c: In function `vortex_up':
 drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in 
 this function
 
 applied as an obvious bug fix (Steffen added to CC)
 

Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from
Satyam Sharma in -mm to fix this, but the patch was removed from -mm
some time ago. Andrew, what happened to this one?

However, this issue should be fixed.

Thanks,

Steffen
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] vortex_up should initialize err

2007-10-18 Thread Andrew Morton 
On Thu, 18 Oct 2007 08:05:06 +0200 Steffen Klassert [EMAIL PROTECTED] wrote:

 On Wed, Oct 17, 2007 at 08:28:36PM -0400, Jeff Garzik wrote:
  Badari Pulavarty wrote:
  Simple compile warning fix. (against 2.6.23-git12)
  
  Thanks,
  Badari
  
  vortex_up() should initialize 'err' for a successful return.
  
  drivers/net/3c59x.c: In function `vortex_up':
  drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in 
  this function
  
  applied as an obvious bug fix (Steffen added to CC)
  
 
 Hm, we had already the 3c59x-fix-uninitialized-variable-bug.patch from
 Satyam Sharma in -mm to fix this, but the patch was removed from -mm
 some time ago. Andrew, what happened to this one?

It's fixed in Jeff's netdev tree.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] vortex_up should initialize err

2007-10-17 Thread Badari Pulavarty 
Simple compile warning fix. (against 2.6.23-git12)

Thanks,
Badari

vortex_up() should initialize 'err' for a successful return.

drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this 
function


Signed-off-by: Badari Pulavarty [EMAIL PROTECTED]
---
 drivers/net/3c59x.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23/drivers/net/3c59x.c
===
--- linux-2.6.23.orig/drivers/net/3c59x.c   2007-10-17 15:33:07.0 
-0700
+++ linux-2.6.23/drivers/net/3c59x.c2007-10-17 16:07:10.0 -0700
@@ -1491,7 +1491,7 @@ vortex_up(struct net_device *dev)
struct vortex_private *vp = netdev_priv(dev);
void __iomem *ioaddr = vp-ioaddr;
unsigned int config;
-   int i, mii_reg1, mii_reg5, err;
+   int i, mii_reg1, mii_reg5, err = 0;
 
if (VORTEX_PCI(vp)) {
pci_set_power_state(VORTEX_PCI(vp), PCI_D0);/* Go active */


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] vortex_up should initialize err

2007-10-17 Thread Jeff Garzik 

Badari Pulavarty wrote:

Simple compile warning fix. (against 2.6.23-git12)

Thanks,
Badari

vortex_up() should initialize 'err' for a successful return.

drivers/net/3c59x.c: In function `vortex_up':
drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this 
function


applied as an obvious bug fix (Steffen added to CC)

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html