Re: [PATCH 0/14] TIPC updates
On Mon, 16 Oct 2006, David Miller wrote: > From: Per Liden <[EMAIL PROTECTED]> > Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST) > > > This patch set includes a number TIPC fixes/cleanups. Please see each > > individual patch for further description. > > > > Please pull from: > > > > git://tipc.cslab.ericsson.net/pub/git/tipc.git > > > > (rebased on linux/kernel/git/davem/net-2.6.git) > > I applied everything except patch 8/14, you really need to > add proper SKB queue locking to handle that race. I think > the "performance cost" of taking that lock is much overstated, > you should never have contention on that lock at all. Ok, we'll take your advice on this. > Secondly, I never pull from your trees because I still have > to make many fixups to your patches: > > 1) Please add a proper colon to your changeset header lines, >it should be "[TIPC]: ", not "[TIPC] ". > > 2) Please check for trailing whitespace added by your patches. >I've given you the command you can use in another email to >check this for yourselve before submission. > > 3) Please get full proper signed-off-by lines from patch submitters, >especially when the patch is more than a trivial 1 or 2 liner. Thanks a lot for the feedback. We'll do our best to assure that we follow these rules in the future. /Per - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 0/14] TIPC updates
From: Per Liden <[EMAIL PROTECTED]> Date: Fri, 13 Oct 2006 13:37:23 +0200 (CEST) > This patch set includes a number TIPC fixes/cleanups. Please see each > individual patch for further description. > > Please pull from: > > git://tipc.cslab.ericsson.net/pub/git/tipc.git > > (rebased on linux/kernel/git/davem/net-2.6.git) I applied everything except patch 8/14, you really need to add proper SKB queue locking to handle that race. I think the "performance cost" of taking that lock is much overstated, you should never have contention on that lock at all. Secondly, I never pull from your trees because I still have to make many fixups to your patches: 1) Please add a proper colon to your changeset header lines, it should be "[TIPC]: ", not "[TIPC] ". 2) Please check for trailing whitespace added by your patches. I've given you the command you can use in another email to check this for yourselve before submission. 3) Please get full proper signed-off-by lines from patch submitters, especially when the patch is more than a trivial 1 or 2 liner. Thanks. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 0/14] TIPC updates
Hi David, This patch set includes a number TIPC fixes/cleanups. Please see each individual patch for further description. Please pull from: git://tipc.cslab.ericsson.net/pub/git/tipc.git (rebased on linux/kernel/git/davem/net-2.6.git) Summary: include/linux/tipc.h |1 net/tipc/bearer.c |8 +-- net/tipc/config.c |5 +- net/tipc/core.c |4 + net/tipc/core.h | 30 ++- net/tipc/dbg.c| 136 - net/tipc/dbg.h| 15 + net/tipc/discover.c | 39 +- net/tipc/link.c |8 +-- net/tipc/name_distr.c |2 - net/tipc/node.c |2 - net/tipc/port.c |7 ++- net/tipc/socket.c | 53 +-- net/tipc/subscr.c | 99 ++-- 14 files changed, 296 insertions(+), 113 deletions(-) Allan Stephens: [TIPC] Add missing unlock in port timeout code. [TIPC] Debug print buffer enhancements and fixes [TIPC] Stream socket can now send > 66000 bytes at a time [TIPC] Added duplicate node address detection capability [TIPC] Optimize wakeup logic when socket has no waiting processes [TIPC] Remove code bloat introduced by print buffer rework [TIPC] Add support for Ethernet VLANs [TIPC] Name publication events now delivered in chronological order [TIPC] Fixed slow link reactivation when link tolerance is large [TIPC] Can now list multicast link on an isolated network node [TIPC] Unrecognized configuration command now returns error message [TIPC] Updated TIPC version number to 1.6.2 Lijun Chen: [TIPC] Added subscription cancellation capability P Litov: [TIPC] Fix socket receive queue NULL pointer dereference on SMP systems /Per - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
