Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
Hi Andrew, On mar., févr. 27 2018, Andrew Lunn wrote: > On Tue, Feb 27, 2018 at 11:24:02AM +0100, Gregory CLEMENT wrote: >> Hi Andrew, >> >> On jeu., févr. 22 2018, Andrew Lunn wrote: >> >> > Not all boards using the mv88e6xxx switches have the interrupt output >> > connected to a GPIO. On these boards phylib has to poll the PHYs, >> > rather than use interrupts. Have the driver poll the interrupt status >> > register, which is more efficient than having phylib do it. And it >> > enables other switch interrupts to be services. >> > >> > The Armada 370RD is such a board without a interrupt GPIO. Now that >> > interrupts work, wire up the PHYs to make use if them. >> > >> > Gregory: Are you O.K. for the second patch to go through netdev? >> >> Why do you need that the second patch to go through netdev. Is there any >> dependency between the 2 patches? >> >> If it is the case does it means that an new kernel won't work with an >> old device tree? > > Hi Gregory > > There is a runtime dependency between the two. A new device tree blob > will not run on an old kernel. So if you take the second patch alone > via mvebu, the PHYs will stop working, no link up reported. > > But an old blob will run on a new kernel. Backwards compatibility is > maintained. Ok so you wanted to keep the kernel bisctable. So I'm fine with having this patch in netdev (and I think it is alrdeay the case). Gregory > > Andrew -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
On Tue, Feb 27, 2018 at 11:24:02AM +0100, Gregory CLEMENT wrote: > Hi Andrew, > > On jeu., févr. 22 2018, Andrew Lunn wrote: > > > Not all boards using the mv88e6xxx switches have the interrupt output > > connected to a GPIO. On these boards phylib has to poll the PHYs, > > rather than use interrupts. Have the driver poll the interrupt status > > register, which is more efficient than having phylib do it. And it > > enables other switch interrupts to be services. > > > > The Armada 370RD is such a board without a interrupt GPIO. Now that > > interrupts work, wire up the PHYs to make use if them. > > > > Gregory: Are you O.K. for the second patch to go through netdev? > > Why do you need that the second patch to go through netdev. Is there any > dependency between the 2 patches? > > If it is the case does it means that an new kernel won't work with an > old device tree? Hi Gregory There is a runtime dependency between the two. A new device tree blob will not run on an old kernel. So if you take the second patch alone via mvebu, the PHYs will stop working, no link up reported. But an old blob will run on a new kernel. Backwards compatibility is maintained. Andrew
Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
Hi Andrew, On jeu., févr. 22 2018, Andrew Lunn wrote: > Not all boards using the mv88e6xxx switches have the interrupt output > connected to a GPIO. On these boards phylib has to poll the PHYs, > rather than use interrupts. Have the driver poll the interrupt status > register, which is more efficient than having phylib do it. And it > enables other switch interrupts to be services. > > The Armada 370RD is such a board without a interrupt GPIO. Now that > interrupts work, wire up the PHYs to make use if them. > > Gregory: Are you O.K. for the second patch to go through netdev? Why do you need that the second patch to go through netdev. Is there any dependency between the 2 patches? If it is the case does it means that an new kernel won't work with an old device tree? Gregory > > Andrew Lunn (2): > net: dsa: mv88e6xxx: Poll when no interrupt defined > arm: mvebu: 370-rd: Enable PHY interrupt handling > > arch/arm/boot/dts/armada-370-rd.dts | 32 > drivers/net/dsa/mv88e6xxx/chip.c| 146 > +--- > drivers/net/dsa/mv88e6xxx/chip.h| 3 + > 3 files changed, 138 insertions(+), 43 deletions(-) > > -- > 2.15.1 > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
On Mon, Feb 26, 2018 at 11:29:58AM -0500, David Miller wrote: > From: Andrew Lunn > Date: Thu, 22 Feb 2018 22:58:31 +0100 > > > Not all boards using the mv88e6xxx switches have the interrupt output > > connected to a GPIO. On these boards phylib has to poll the PHYs, > > rather than use interrupts. Have the driver poll the interrupt status > > register, which is more efficient than having phylib do it. And it > > enables other switch interrupts to be services. > > > > The Armada 370RD is such a board without a interrupt GPIO. Now that > > interrupts work, wire up the PHYs to make use if them. > > > > Gregory: Are you O.K. for the second patch to go through netdev? > > Still no response from Gregory after 4+ days, so I'm applying this > to net-next. Hi David I pinged Gregory earlier today. He said he was on vacation last week, and you get to it later today or tomorrow. Andrew
Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
From: Andrew Lunn Date: Thu, 22 Feb 2018 22:58:31 +0100 > Not all boards using the mv88e6xxx switches have the interrupt output > connected to a GPIO. On these boards phylib has to poll the PHYs, > rather than use interrupts. Have the driver poll the interrupt status > register, which is more efficient than having phylib do it. And it > enables other switch interrupts to be services. > > The Armada 370RD is such a board without a interrupt GPIO. Now that > interrupts work, wire up the PHYs to make use if them. > > Gregory: Are you O.K. for the second patch to go through netdev? Still no response from Gregory after 4+ days, so I'm applying this to net-next. Thanks Andrew.
Re: [PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
From: Andrew Lunn Date: Thu, 22 Feb 2018 22:58:31 +0100 > Not all boards using the mv88e6xxx switches have the interrupt output > connected to a GPIO. On these boards phylib has to poll the PHYs, > rather than use interrupts. Have the driver poll the interrupt status > register, which is more efficient than having phylib do it. And it > enables other switch interrupts to be services. > > The Armada 370RD is such a board without a interrupt GPIO. Now that > interrupts work, wire up the PHYs to make use if them. > > Gregory: Are you O.K. for the second patch to go through netdev? I'll wait for Gregory's response before applying this series.
[PATCH 0/2] mv88e6xxx: Poll when no interrupt defined
Not all boards using the mv88e6xxx switches have the interrupt output connected to a GPIO. On these boards phylib has to poll the PHYs, rather than use interrupts. Have the driver poll the interrupt status register, which is more efficient than having phylib do it. And it enables other switch interrupts to be services. The Armada 370RD is such a board without a interrupt GPIO. Now that interrupts work, wire up the PHYs to make use if them. Gregory: Are you O.K. for the second patch to go through netdev? Andrew Lunn (2): net: dsa: mv88e6xxx: Poll when no interrupt defined arm: mvebu: 370-rd: Enable PHY interrupt handling arch/arm/boot/dts/armada-370-rd.dts | 32 drivers/net/dsa/mv88e6xxx/chip.c| 146 +--- drivers/net/dsa/mv88e6xxx/chip.h| 3 + 3 files changed, 138 insertions(+), 43 deletions(-) -- 2.15.1
