Re: [PATCH 0/5] net: macb: Checkpatch cleanups

2016-03-19 Thread Moritz Fischer
Nicolas,

On Wed, Mar 16, 2016 at 6:39 AM, Nicolas Ferre  wrote:
> Le 13/03/2016 20:10, Moritz Fischer a écrit :
>> Hi all,
>>
>> I backed out the variable scope changes and made a separate
>> patch for the ether_addr_copy change.
>>
>> Changes from v1:
>
> As it's v2, it's better to add it in each subject of the patch series like:
> "[PATCH v2 0/5] net: macb: Checkpatch cleanups"

Yeah, I fat-fingered that.  Figured it is less annoying than resending
the series immediately.
Do you want me to resend the series as v3 with Acked-bys and fixed patch 5?
Through which tree will this go?

Merci,

Moritz


Re: [PATCH 0/5] net: macb: Checkpatch cleanups

2016-03-18 Thread Nicolas Ferre
Le 13/03/2016 20:10, Moritz Fischer a écrit :
> Hi all,
> 
> I backed out the variable scope changes and made a separate
> patch for the ether_addr_copy change.
> 
> Changes from v1:

As it's v2, it's better to add it in each subject of the patch series like:
"[PATCH v2 0/5] net: macb: Checkpatch cleanups"


> * Backed out variable scope changes
> * Separated out ether_addr_copy into it's own commit
> * Fixed typo in comments as suggested by Joe
> 
> Cheers,
> 
> Moritz
> 
> Moritz Fischer (5):
>   net: macb: Fix coding style error message
>   net: macb: Fix coding style warnings
>   net: macb: Address checkpatch 'check' suggestions
>   net: macb: Use ether_addr_copy over memcpy
>   net: macb: Fix simple typo.
> 
>  drivers/net/ethernet/cadence/macb.c | 153 
> +---
>  1 file changed, 70 insertions(+), 83 deletions(-)
> 


-- 
Nicolas Ferre


[PATCH 0/5] net: macb: Checkpatch cleanups

2016-03-13 Thread Moritz Fischer
Hi all,

I backed out the variable scope changes and made a separate
patch for the ether_addr_copy change.

Changes from v1:
* Backed out variable scope changes
* Separated out ether_addr_copy into it's own commit
* Fixed typo in comments as suggested by Joe

Cheers,

Moritz

Moritz Fischer (5):
  net: macb: Fix coding style error message
  net: macb: Fix coding style warnings
  net: macb: Address checkpatch 'check' suggestions
  net: macb: Use ether_addr_copy over memcpy
  net: macb: Fix simple typo.

 drivers/net/ethernet/cadence/macb.c | 153 +---
 1 file changed, 70 insertions(+), 83 deletions(-)

-- 
2.4.3