Re: [PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and enhancements

[David Miller]

From: Thomas Falcon 
Date: Mon, 26 Feb 2018 18:10:54 -0600

> There is not a general theme to this patch set other than that it
> fixes a few issues with the ibmvnic driver. I will just give a quick
> summary of what each patch does here.
> 
> "ibmvnic: Fix TX descriptor tracking again" resolves a race condition
> introduced in an earlier fix to track outstanding transmit descriptors.
> This condition can throw off the tracking counter to the point that
> a transmit queue will halt forever.
> 
> "ibmvnic: Allocate statistics buffers during probe" allocates queue
> statistics buffers on device probe to avoid a crash when accessing
> statistics of an unopened interface.
> 
> "ibmvnic: Harden TX/RX pool cleaning" includes additional checks to
> avoid a bad access when cleaning RX and TX buffer pools during a device
> reset.
> 
> "ibmvnic: Report queue stops and restarts as debug output" changes TX
> queue state notifications from informational to debug messages. This
> information is not necessarily useful to a user and under load can result
> in a lot of log output.
> 
> "ibmvnic: Do not attempt to login if RX or TX queues are not allocated"
> checks that device queues have been allocated successfully before
> attempting device login. This resolves a panic that could occur if a
> user attempted to configure a device after a failed reset.
> 
> Thanks for your attention.

Series applied, thanks Thomas.

[PATCH 0/5 net-next] ibmvnic: Miscellaneous driver fixes and enhancements

[Thomas Falcon]

There is not a general theme to this patch set other than that it
fixes a few issues with the ibmvnic driver. I will just give a quick
summary of what each patch does here.

"ibmvnic: Fix TX descriptor tracking again" resolves a race condition
introduced in an earlier fix to track outstanding transmit descriptors.
This condition can throw off the tracking counter to the point that
a transmit queue will halt forever.

"ibmvnic: Allocate statistics buffers during probe" allocates queue
statistics buffers on device probe to avoid a crash when accessing
statistics of an unopened interface.

"ibmvnic: Harden TX/RX pool cleaning" includes additional checks to
avoid a bad access when cleaning RX and TX buffer pools during a device
reset.

"ibmvnic: Report queue stops and restarts as debug output" changes TX
queue state notifications from informational to debug messages. This
information is not necessarily useful to a user and under load can result
in a lot of log output.

"ibmvnic: Do not attempt to login if RX or TX queues are not allocated"
checks that device queues have been allocated successfully before
attempting device login. This resolves a panic that could occur if a
user attempted to configure a device after a failed reset.

Thanks for your attention.

Thomas Falcon (5):
  ibmvnic: Fix TX descriptor tracking again
  ibmvnic: Allocate statistics buffers during probe
  ibmvnic: Harden TX/RX pool cleaning
  ibmvnic: Report queue stops and restarts as debug output
  ibmvnic: Do not attempt to login if RX or TX queues are not allocated

 drivers/net/ethernet/ibm/ibmvnic.c | 71 +++---
 1 file changed, 43 insertions(+), 28 deletions(-)

-- 
2.15.0