Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Fri, Nov 9, 2018 at 5:35 AM Sunil Kovvuri wrote: > On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:36 PM wrote: > > > From: Sunil Goutham > > > > Hmm, I noticed that you use a different address as the patch author > > and the submitter. I'm guessing that "Sunil Goutham" and > > "Sunil Kovvuri" actually refer to the same person, and you just > > need to pick which of the two email addresses you want to use > > for public communication, but that's not obvious here. > > > > However, if there are actually two different Sunil's here, then > > you need to add that second Signed-off-by. > > > > No, it's just me. > Sometimes code indentation becomes messy and difficult to read, if i use > corporate mail server to submit patches. So i have been using gmail. Ok, I see. Ideally you should try to get the company mail server fixed of course. A possible workaround is to add your marvell address as an alias in gmail, which allows 'git send email' to send out mails with the other address as the sender. This may however fail if the marvell mail server uses SPF, as mail clients might then consider your mails as forged. Arnd
Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Fri, Nov 9, 2018 at 2:32 AM Arnd Bergmann wrote: > > On Thu, Nov 8, 2018 at 7:36 PM wrote: > > > > From: Sunil Goutham > > Hmm, I noticed that you use a different address as the patch author > and the submitter. I'm guessing that "Sunil Goutham" and > "Sunil Kovvuri" actually refer to the same person, and you just > need to pick which of the two email addresses you want to use > for public communication, but that's not obvious here. > > However, if there are actually two different Sunil's here, then > you need to add that second Signed-off-by. > No, it's just me. Sometimes code indentation becomes messy and difficult to read, if i use corporate mail server to submit patches. So i have been using gmail. > I've taken a look at all the patches now, and found very little > sticking out that warranted a comment from my side, and > no real show-stoppers. That said, I found this series overall > much harder to understand than the previous ones, and don't > even know what to ask about it. My feeling is that it's probably > all fine, but that is purely based on a review of the individual > pieces, not the overall design and how they fit together. With the > earlier patches that I managed to get a better understanding > of, that seemed reasonable as well. > > Arnd
Re: [PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
On Thu, Nov 8, 2018 at 7:36 PM wrote: > > From: Sunil Goutham Hmm, I noticed that you use a different address as the patch author and the submitter. I'm guessing that "Sunil Goutham" and "Sunil Kovvuri" actually refer to the same person, and you just need to pick which of the two email addresses you want to use for public communication, but that's not obvious here. However, if there are actually two different Sunil's here, then you need to add that second Signed-off-by. I've taken a look at all the patches now, and found very little sticking out that warranted a comment from my side, and no real show-stoppers. That said, I found this series overall much harder to understand than the previous ones, and don't even know what to ask about it. My feeling is that it's probably all fine, but that is purely based on a review of the individual pieces, not the overall design and how they fit together. With the earlier patches that I managed to get a better understanding of, that seemed reasonable as well. Arnd
[PATCH 00/20] octeontx2-af: NPC MCAM support and FLR handling
From: Sunil Goutham This patchset is a continuation to earlier submitted three patch series to add a new driver for Marvell's OcteonTX2 SOC's Resource virtualization unit (RVU) admin function driver. 1. octeontx2-af: Add RVU Admin Function driver https://www.spinics.net/lists/netdev/msg528272.html 2. octeontx2-af: NPA and NIX blocks initialization https://www.spinics.net/lists/netdev/msg529163.html 3. octeontx2-af: NPC parser and NIX blocks initialization https://www.spinics.net/lists/netdev/msg530252.html This patch series adds support for below RVU generic: - Function Level Reset irq handler When FLR is triggered for PFs, AF receives interrupt. This patchset adds logic for cleaning up of NPA, NIX and NPC block resources being used by PF. - Mailbox communication between AF and it's VFs. Unlike VFs of PF1-PFn, AF which is PF0 can communicate with it's VFs directly. Added support for the same. - AF's VFs IO configuration These VFs are mapped to use internal HW loopback channels instead of CGX LMACs. Each pair of VFs work as two of ends of hardwired interfaces. VF0's TX is VF1's Rx & viceversa. NPC block: - MCAM entry management Alloc/Free of contiguous/non-contiguous and lower/higher priority MCAM entry allocation and programming support. - MCAM counters management and map/unmap with MCAM entries - Default KEY extract profile - HW errata workarounds NIX block: - Minimum and maximum allowed packet length config - HW errata workarounds Few more changes like shift to use mutex instead of spinlock etc are done in this patchset. Geetha sowjanya (2): octeontx2-af: Add FLR interrupt handler octeontx2-af: Teardown NPA, NIX LF upon receiving FLR Kiran Kumar (1): octeontx2-af: Support to get NIX HW constants from AF Linu Cherian (1): octeontx2-af: Add interrupt handlers for Master Enable event Santosh Shukla (1): octeontx2-af: Add MKEX default profile Stanislaw Kardach (1): octeontx2-af: Relax resource lock into mutex Sunil Goutham (10): octeontx2-af: Support to modify min/max allowed packet lengths octeontx2-af: NPC MCAM entry alloc/free support octeontx2-af: MCAM entry installation support octeontx2-af: Support for NPC MCAM counters octeontx2-af: Map or unmap NPC MCAM entry and counter octeontx2-af: Alloc and config NPC MCAM entry at a time octeontx2-af: Support to enable/disable default MCAM entries octeontx2-af: Verify NPA/SSO/NIX PF_FUNC mapping octeontx2-af: Add FLR handling support for AF's VFs octeontx2-af: Workarounds for HW errata Tomasz Duszynski (4): octeontx2-af: Add support for stripping STAG/CTAG octeontx2-af: Mbox communication support btw AF and it's VFs octeontx2-af: Enable sriov on AF to create VFs octeontx2-af: Configure AF VFs to talk over LBK channels drivers/net/ethernet/marvell/octeontx2/af/cgx.h|1 + drivers/net/ethernet/marvell/octeontx2/af/common.h |7 + drivers/net/ethernet/marvell/octeontx2/af/mbox.h | 200 ++- drivers/net/ethernet/marvell/octeontx2/af/npc.h| 30 + drivers/net/ethernet/marvell/octeontx2/af/rvu.c| 937 +++-- drivers/net/ethernet/marvell/octeontx2/af/rvu.h| 118 +- .../net/ethernet/marvell/octeontx2/af/rvu_cgx.c|6 +- .../net/ethernet/marvell/octeontx2/af/rvu_nix.c| 495 ++- .../net/ethernet/marvell/octeontx2/af/rvu_npa.c| 17 + .../net/ethernet/marvell/octeontx2/af/rvu_npc.c| 1386 +++- 10 files changed, 2975 insertions(+), 222 deletions(-) -- 2.7.4
