Re: [PATCH 08/18] d80211: clean up exports

2006-08-23 Thread Johannes Berg 
On Tue, 2006-08-22 at 09:44 -0700, Jouni Malinen wrote:

> Moving the EXPORT_SYMBOL definitions sounds good, but I would like to
> keep changes between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL separate from
> this kind of cleanup. In addition, I'm not personally a huge fan of the
> EXPORT_SYMBOL_GPL in the first place since I believe the GPL should
> cover this without additional changes in the source code. In other
> words, I would prefer that the EXPORT_SYMBOL would not be changed to
> EXPORT_SYMBOL_GPL here.

I just intended making it _GPL as an additional deterrent since you
practically need the internal ieee80211_i.h header for any kind of rate
control algorithm. I'm fine with dropping them, however.

johannes
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 08/18] d80211: clean up exports

2006-08-22 Thread Jouni Malinen 
On Mon, Aug 21, 2006 at 09:41:15AM +0200, Johannes Berg wrote:
> This puts all EXPORT_SYMBOL() macros along with the function being exported,
> and changes some exports that are only relevant to rate control modules
> and to be GPL-only because they rate control modules need to be built against
> the internal ieee80211_i.h header.

Moving the EXPORT_SYMBOL definitions sounds good, but I would like to
keep changes between EXPORT_SYMBOL and EXPORT_SYMBOL_GPL separate from
this kind of cleanup. In addition, I'm not personally a huge fan of the
EXPORT_SYMBOL_GPL in the first place since I believe the GPL should
cover this without additional changes in the source code. In other
words, I would prefer that the EXPORT_SYMBOL would not be changed to
EXPORT_SYMBOL_GPL here.

-- 
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 08/18] d80211: clean up exports

2006-08-21 Thread Johannes Berg 
This puts all EXPORT_SYMBOL() macros along with the function being exported,
and changes some exports that are only relevant to rate control modules
and to be GPL-only because they rate control modules need to be built against
the internal ieee80211_i.h header.

Signed-off-by: Johannes Berg <[EMAIL PROTECTED]>

--- wireless-dev.orig/net/d80211/ieee80211.c2006-08-20 14:56:20.578192788 
+0200
+++ wireless-dev/net/d80211/ieee80211.c 2006-08-20 14:56:21.308192788 +0200
@@ -267,6 +267,7 @@ int ieee80211_get_hdrlen(u16 fc)
 
return hdrlen;
 }
+EXPORT_SYMBOL(ieee80211_get_hdrlen);
 
 
 int ieee80211_get_hdrlen_from_skb(struct sk_buff *skb)
@@ -281,6 +282,7 @@ int ieee80211_get_hdrlen_from_skb(struct
return 0;
return hdrlen;
 }
+EXPORT_SYMBOL(ieee80211_get_hdrlen_from_skb);
 
 
 #ifdef IEEE80211_VERBOSE_DEBUG_FRAME_DUMP
@@ -1817,6 +1819,7 @@ struct sk_buff * ieee80211_beacon_get(st
ap->num_beacons++;
return skb;
 }
+EXPORT_SYMBOL(ieee80211_beacon_get);
 
 
 struct sk_buff *
@@ -1883,6 +1886,7 @@ ieee80211_get_buffered_bc(struct net_dev
 
return skb;
 }
+EXPORT_SYMBOL(ieee80211_get_buffered_bc);
 
 static int __ieee80211_if_config(struct net_device *dev,
 struct sk_buff *beacon)
@@ -1967,6 +1971,7 @@ struct ieee80211_conf *ieee80211_get_hw_
struct ieee80211_local *local = dev->ieee80211_ptr;
 return &local->conf;
 }
+EXPORT_SYMBOL(ieee80211_get_hw_conf);
 
 
 static int ieee80211_change_mtu(struct net_device *dev, int new_mtu)
@@ -2098,6 +2103,7 @@ struct dev_mc_list *ieee80211_get_mc_lis
*ptr = sdata;
return mc;
 }
+EXPORT_SYMBOL(ieee80211_get_mc_list_item);
 
 static struct net_device_stats *ieee80211_get_stats(struct net_device *dev)
 {
@@ -2645,6 +2651,7 @@ int ieee80211_radar_status(struct net_de
ieee80211_rx_mgmt(dev, skb, 0, ieee80211_msg_radar);
return 0;
 }
+EXPORT_SYMBOL(ieee80211_radar_status);
 
 
 int ieee80211_set_aid_for_sta(struct net_device *dev, u8 *peer_address,
@@ -2668,6 +2675,7 @@ int ieee80211_set_aid_for_sta(struct net
 ieee80211_rx_mgmt(dev, skb, 0, ieee80211_msg_set_aid_for_sta);
 return 0;
 }
+EXPORT_SYMBOL(ieee80211_set_aid_for_sta);
 
 
 static void ap_sta_ps_start(struct net_device *dev, struct sta_info *sta)
@@ -3693,6 +3701,7 @@ void __ieee80211_rx(struct net_device *d
if (sta)
sta_info_put(sta);
 }
+EXPORT_SYMBOL(__ieee80211_rx);
 
 
 static ieee80211_txrx_result
@@ -3866,6 +3875,7 @@ void ieee80211_rx_irqsafe(struct net_dev
 skb_queue_tail(&local->skb_queue, skb);
 tasklet_schedule(&local->tasklet);
 }
+EXPORT_SYMBOL(ieee80211_rx_irqsafe);
 
 
 void ieee80211_tx_status_irqsafe(struct net_device *dev, struct sk_buff *skb,
@@ -3895,6 +3905,7 @@ void ieee80211_tx_status_irqsafe(struct 
}
 tasklet_schedule(&local->tasklet);
 }
+EXPORT_SYMBOL(ieee80211_tx_status_irqsafe);
 
 
 static void ieee80211_tasklet_handler(unsigned long data)
@@ -4146,6 +4157,7 @@ void ieee80211_tx_status(struct net_devi
 /* Send frame to hostapd */
 ieee80211_rx_mgmt(dev, skb, NULL, msg_type);
 }
+EXPORT_SYMBOL(ieee80211_tx_status);
 
 
 /* TODO: implement register/unregister functions for adding TX/RX handlers
@@ -4398,6 +4410,7 @@ struct net_device *ieee80211_alloc_hw(si
 
return mdev;
 }
+EXPORT_SYMBOL(ieee80211_alloc_hw);
 
 
 int ieee80211_register_hw(struct net_device *dev, struct ieee80211_hw *hw)
@@ -4503,6 +4516,7 @@ fail_sysfs:
ieee80211_dev_free_index(local);
return result;
 }
+EXPORT_SYMBOL(ieee80211_register_hw);
 
 int ieee80211_update_hw(struct net_device *dev, struct ieee80211_hw *hw)
 {
@@ -4534,6 +4548,7 @@ int ieee80211_update_hw(struct net_devic
 
return 0;
 }
+EXPORT_SYMBOL(ieee80211_update_hw);
 
 
 void ieee80211_unregister_hw(struct net_device *dev)
@@ -4592,6 +4607,7 @@ void ieee80211_unregister_hw(struct net_
ieee80211_dev_free_index(local);
ieee80211_led_exit(local);
 }
+EXPORT_SYMBOL(ieee80211_unregister_hw);
 
 void ieee80211_free_hw(struct net_device *dev)
 {
@@ -4601,6 +4617,7 @@ void ieee80211_free_hw(struct net_device
ieee80211_wep_free(local);
ieee80211_dev_free(local);
 }
+EXPORT_SYMBOL(ieee80211_free_hw);
 
 void ieee80211_release_hw(struct ieee80211_local *local)
 {
@@ -4647,6 +4664,7 @@ int ieee80211_netif_oper(struct net_devi
 
 return 0;
 }
+EXPORT_SYMBOL(ieee80211_netif_oper);
 
 void ieee80211_wake_queue(struct net_device *dev, int queue)
 {
@@ -4661,6 +4679,7 @@ void ieee80211_wake_queue(struct net_dev
__netif_schedule(dev);
}
 }
+EXPORT_SYMBOL(ieee80211_wake_queue);
 
 void ieee80211_stop_queue(struct net_device *dev, int queue)
 {
@@ -4668,6 +4687,7 @@ void ieee80211_stop_queue(struct net_dev
 
set_bit(IEEE80211_LINK_STATE_XOFF, &local->state[queue]);
 }
+EXPORT_SYMBOL(ieee80211_stop_queue);
 
 void ieee80211_start_queues(struct net_