Re: [PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread David Miller 
From: Santosh Shilimkar 
Date: Fri, 24 Feb 2017 08:49:19 -0800

> On 2/24/2017 1:28 AM, Zhu Yanjun wrote:
>> When the function register_netdevice_notifier fails, the memory
>> allocated by kmem_cache_create should be freed by the function
>> kmem_cache_destroy.
>>
>> Cc: Joe Jin 
>> Cc: Junxiao Bi 
>> Signed-off-by: Zhu Yanjun 
>> ---
> Minor nit with subject.
> s/rds/RDS: TCP:

Please, I definitely prefer people use all lowercase letters for
the susbsystem prefix in the subject line.

Re: [PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread santosh.shilim...@oracle.com 

On 2/24/17 11:12 AM, David Miller wrote:

From: Santosh Shilimkar 
Date: Fri, 24 Feb 2017 08:49:19 -0800


On 2/24/2017 1:28 AM, Zhu Yanjun wrote:

When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.

Cc: Joe Jin 
Cc: Junxiao Bi 
Signed-off-by: Zhu Yanjun 
---

Minor nit with subject.
s/rds/RDS: TCP:


Please, I definitely prefer people use all lowercase letters for
the susbsystem prefix in the subject line.


Note for the future. Thanks Dave !!

Regards,
Santosh

Re: [PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread David Miller 
From: Zhu Yanjun 
Date: Fri, 24 Feb 2017 04:28:01 -0500

> When the function register_netdevice_notifier fails, the memory
> allocated by kmem_cache_create should be freed by the function
> kmem_cache_destroy.
> 
> Cc: Joe Jin 
> Cc: Junxiao Bi 
> Signed-off-by: Zhu Yanjun 

Applied, thank you.

Re: [PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread sowmini 



On 02/24/2017 04:28 AM, Zhu Yanjun wrote:

When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.

Cc: Joe Jin 
Cc: Junxiao Bi 
Signed-off-by: Zhu Yanjun 


Acked-by: Sowmini Varadhan

Re: [PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread Santosh Shilimkar 

On 2/24/2017 1:28 AM, Zhu Yanjun wrote:

When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.

Cc: Joe Jin 
Cc: Junxiao Bi 
Signed-off-by: Zhu Yanjun 
---

Minor nit with subject.
s/rds/RDS: TCP:

patch looks fine to me.
Acked:by: Santosh Shilimkar

[PATCH 1/1] rds: fix memory leak error

2017-02-24 Thread Zhu Yanjun 
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.

Cc: Joe Jin 
Cc: Junxiao Bi 
Signed-off-by: Zhu Yanjun 
---
 net/rds/tcp.c | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/rds/tcp.c b/net/rds/tcp.c
index 57bb523..5438f67 100644
--- a/net/rds/tcp.c
+++ b/net/rds/tcp.c
@@ -641,12 +641,12 @@ static int rds_tcp_init(void)
ret = register_netdevice_notifier(_tcp_dev_notifier);
if (ret) {
pr_warn("could not register rds_tcp_dev_notifier\n");
-   goto out;
+   goto out_slab;
}
 
ret = register_pernet_subsys(_tcp_net_ops);
if (ret)
-   goto out_slab;
+   goto out_notifier;
 
ret = rds_tcp_recv_init();
if (ret)
@@ -664,9 +664,10 @@ static int rds_tcp_init(void)
rds_tcp_recv_exit();
 out_pernet:
unregister_pernet_subsys(_tcp_net_ops);
-out_slab:
+out_notifier:
if (unregister_netdevice_notifier(_tcp_dev_notifier))
pr_warn("could not unregister rds_tcp_dev_notifier\n");
+out_slab:
kmem_cache_destroy(rds_tcp_conn_slab);
 out:
return ret;
-- 
2.7.4