[PATCH 1/2] !CONFIG_NET_ETHERNET unsets CONFIG_PHYLIB, but CONFIG_USB_USBNET also needs CONFIG_PHYLIB
On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote: The other parts are right, this isn't. Instead, usbnet.c should #ifdef the relevant ethtool hooks according to CONFIG_MII ... since it's completely legit to use usbnet with peripherals that don't need MII. Ugh. OK. How's this? (2 patches) (oh, OP mentioned CONFIG_PHYLIB but it's actually CONFIG_MII AFAIK) --- From: Randy Dunlap [EMAIL PROTECTED] pegasus and mcs7830 drivers use MII interfaces and should select MII in the same way that drivers/net/ drivers do. However, the MII config symbol should not be in the 10/100 Ethernet menu, so that other drivers can use (enable) it or so that users can enable it without needing to enable 10/100 Ethernet. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/net/Kconfig | 15 +++ drivers/usb/net/Kconfig |2 ++ 2 files changed, 9 insertions(+), 8 deletions(-) --- linux-2619-rc3-pv.orig/drivers/usb/net/Kconfig +++ linux-2619-rc3-pv/drivers/usb/net/Kconfig @@ -84,6 +84,7 @@ config USB_PEGASUS config USB_RTL8150 tristate USB RTL8150 based ethernet device support (EXPERIMENTAL) depends on EXPERIMENTAL + select MII help Say Y here if you have RTL8150 based usb-ethernet adapter. Send me [EMAIL PROTECTED] any comments you may have. @@ -210,6 +211,7 @@ config USB_NET_PLUSB config USB_NET_MCS7830 tristate MosChip MCS7830 based Ethernet adapters depends on USB_USBNET + select MII help Choose this option if you're using a 10/100 Ethernet USB2 adapter based on the MosChip 7830 controller. This includes --- linux-2619-rc3-pv.orig/drivers/net/Kconfig +++ linux-2619-rc3-pv/drivers/net/Kconfig @@ -145,6 +145,13 @@ config NET_SB1000 source drivers/net/arcnet/Kconfig +config MII + tristate Generic Media Independent Interface device support + help + Most ethernet controllers have MII transceiver either as an external + or internal device. It is safe to say Y or M here even if your + ethernet card lacks MII. + source drivers/net/phy/Kconfig # @@ -180,14 +187,6 @@ config NET_ETHERNET kernel: saying N will just cause the configurator to skip all the questions about Ethernet network cards. If unsure, say N. -config MII - tristate Generic Media Independent Interface device support - depends on NET_ETHERNET - help - Most ethernet controllers have MII transceiver either as an external - or internal device. It is safe to say Y or M here even if your - ethernet card lack MII. - source drivers/net/arm/Kconfig config MACE - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] !CONFIG_NET_ETHERNET unsets CONFIG_PHYLIB, but CONFIG_USB_USBNET also needs CONFIG_PHYLIB
On Wednesday 25 October 2006 4:59 pm, Randy Dunlap wrote: On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote: The other parts are right, this isn't. Instead, usbnet.c should #ifdef the relevant ethtool hooks according to CONFIG_MII ... since it's completely legit to use usbnet with peripherals that don't need MII. Ugh. OK. How's this? (2 patches) Looks about right, but ... However, the MII config symbol should not be in the 10/100 Ethernet menu, so that other drivers can use (enable) it or so that users can enable it without needing to enable 10/100 Ethernet. ... MII should still depend on ETHERNET, right? Just not limited to 10/100 Ethernet. --- linux-2619-rc3-pv.orig/drivers/net/Kconfig +++ linux-2619-rc3-pv/drivers/net/Kconfig @@ -145,6 +145,13 @@ config NET_SB1000 source drivers/net/arcnet/Kconfig +config MII + tristate Generic Media Independent Interface device support + help + Most ethernet controllers have MII transceiver either as an external + or internal device. It is safe to say Y or M here even if your + ethernet card lacks MII. + source drivers/net/phy/Kconfig # @@ -180,14 +187,6 @@ config NET_ETHERNET kernel: saying N will just cause the configurator to skip all the questions about Ethernet network cards. If unsure, say N. -config MII - tristate Generic Media Independent Interface device support - depends on NET_ETHERNET - help - Most ethernet controllers have MII transceiver either as an external - or internal device. It is safe to say Y or M here even if your - ethernet card lack MII. - source drivers/net/arm/Kconfig config MACE - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] !CONFIG_NET_ETHERNET unsets CONFIG_PHYLIB, but CONFIG_USB_USBNET also needs CONFIG_PHYLIB
David Brownell wrote: On Wednesday 25 October 2006 4:59 pm, Randy Dunlap wrote: On Wed, 25 Oct 2006 15:27:09 -0700 David Brownell wrote: The other parts are right, this isn't. Instead, usbnet.c should #ifdef the relevant ethtool hooks according to CONFIG_MII ... since it's completely legit to use usbnet with peripherals that don't need MII. Ugh. OK. How's this? (2 patches) Looks about right, but ... However, the MII config symbol should not be in the 10/100 Ethernet menu, so that other drivers can use (enable) it or so that users can enable it without needing to enable 10/100 Ethernet. ... MII should still depend on ETHERNET, right? Just not limited to 10/100 Ethernet. There is no such config symbol. NET_ETHERNET means 10/100 ethernet. Gigabit ethernet doesn't use the ETHERNET symbol (and doesn't use this flavor of MII IIRC). And all of this config space is surrounded by: # All the following symbols are dependent on NETDEVICES - do not repeat # that for each of the symbols. if NETDEVICES so it is actually config MII depends on NETDEVICES What do you suggest? --- linux-2619-rc3-pv.orig/drivers/net/Kconfig +++ linux-2619-rc3-pv/drivers/net/Kconfig @@ -145,6 +145,13 @@ config NET_SB1000 source drivers/net/arcnet/Kconfig +config MII + tristate Generic Media Independent Interface device support + help + Most ethernet controllers have MII transceiver either as an external + or internal device. It is safe to say Y or M here even if your + ethernet card lacks MII. + source drivers/net/phy/Kconfig # @@ -180,14 +187,6 @@ config NET_ETHERNET kernel: saying N will just cause the configurator to skip all the questions about Ethernet network cards. If unsure, say N. -config MII - tristate Generic Media Independent Interface device support - depends on NET_ETHERNET - help - Most ethernet controllers have MII transceiver either as an external - or internal device. It is safe to say Y or M here even if your - ethernet card lack MII. - source drivers/net/arm/Kconfig config MACE -- ~Randy - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/2] !CONFIG_NET_ETHERNET unsets CONFIG_PHYLIB, but CONFIG_USB_USBNET also needs CONFIG_PHYLIB
On Wednesday 25 October 2006 10:05 pm, Randy.Dunlap wrote: ... MII should still depend on ETHERNET, right? Just not limited to 10/100 Ethernet. There is no such config symbol. NET_ETHERNET means 10/100 ethernet. Gigabit ethernet doesn't use the ETHERNET symbol (and doesn't use this flavor of MII IIRC). Ah, you're right -- sorry. Only Kconfig and net/ipv4/arp.c even look for that config symbol. - Dave - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
