[PATCH 1/4] [IPV4]: Only panic if inetdev_init fails for loopback

2007-06-05 Thread Herbert Xu
[IPV4]: Only panic if inetdev_init fails for loopback

When I made the inetdev_init call work on all devices I incorrectly
left in the panic call as well.  It is obviously undesirable to
panic on an allocation failure for a normal network device.  This
patch moves the panic call under the loopback if clause.

Signed-off-by: Herbert Xu [EMAIL PROTECTED]
---

 net/ipv4/devinet.c |5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c
--- a/net/ipv4/devinet.c
+++ b/net/ipv4/devinet.c
@@ -1057,9 +1057,10 @@ static int inetdev_event(struct notifier
if (!in_dev) {
if (event == NETDEV_REGISTER) {
in_dev = inetdev_init(dev);
-   if (!in_dev)
-   panic(devinet: Failed to create loopback\n);
if (dev == loopback_dev) {
+   if (!in_dev)
+   panic(devinet: 
+ Failed to create loopback\n);
in_dev-cnf.no_xfrm = 1;
in_dev-cnf.no_policy = 1;
}
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 1/4] [IPV4]: Only panic if inetdev_init fails for loopback

2007-06-05 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED]
Date: Tue, 05 Jun 2007 16:31:01 +1000

 [IPV4]: Only panic if inetdev_init fails for loopback
 
 When I made the inetdev_init call work on all devices I incorrectly
 left in the panic call as well.  It is obviously undesirable to
 panic on an allocation failure for a normal network device.  This
 patch moves the panic call under the loopback if clause.
 
 Signed-off-by: Herbert Xu [EMAIL PROTECTED]

Applied.
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html