Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Dan Williams 
On Tue, 2006-08-08 at 18:58 -0500, Larry Finger wrote:
 Part 1 of 8 to add wireless statistics to the bcm43xx-d80211 system. This 
 patch adds new variables
 to struct ieee80211_rx_status to contain the latest values for signal, noise, 
 and the maximum value
 of the received ssi. These could be u8's, but I left them as integers in case 
 other drivers needed
 larger values.
 
 The patch is for the August 8 version of Linville's wireless-dev tree.
 
 Signed-Off-By: Larry Finger [EMAIL PROTECTED]
 
 
 
 
 diff --git a/include/net/d80211.h b/include/net/d80211.h
 index ba5cb4c..8479b58 100644
 --- a/include/net/d80211.h
 +++ b/include/net/d80211.h
 @@ -205,6 +205,9 @@ struct ieee80211_rx_status {
   int channel;
   int phymode;
   int ssi;
 + int maxssi;
 + int signal;
 + int noise;

Spacing?  Looks like you're using real tabs here, but the current code
uses 8 spaces instead.  Not sure if that's a problem.

Dan

   int antenna;
   int rate;
   int flag;
 
 
 -
 To unsubscribe from this list: send the line unsubscribe netdev in
 the body of a message to [EMAIL PROTECTED]
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Larry Finger 

Dan Williams wrote:

On Tue, 2006-08-08 at 18:58 -0500, Larry Finger wrote:


diff --git a/include/net/d80211.h b/include/net/d80211.h
index ba5cb4c..8479b58 100644
--- a/include/net/d80211.h
+++ b/include/net/d80211.h
@@ -205,6 +205,9 @@ struct ieee80211_rx_status {
  int channel;
  int phymode;
  int ssi;
+   int maxssi;
+   int signal;
+   int noise;


Spacing?  Looks like you're using real tabs here, but the current code
uses 8 spaces instead.  Not sure if that's a problem.


I am using tabs, which I think is the preferred way. I also remember that the 
rule is not to change the white space on things you are not touching. Is that 
correct?


Larry

-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-09 Thread Jouni Malinen 
On Wed, Aug 09, 2006 at 10:21:16AM -0500, Larry Finger wrote:
 Dan Williams wrote:
   int ssi;
 +   int maxssi;

 Spacing?  Looks like you're using real tabs here, but the current code
 uses 8 spaces instead.  Not sure if that's a problem.
 
 I am using tabs, which I think is the preferred way. I also remember that 
 the rule is not to change the white space on things you are not touching. 
 Is that correct?

That's at least the way I would prefer to do this. Unrelated whitespace
changes as part of a patch are almost always bad and large patch of
modifying just the whitespaces around the tree is likely to add large
number of conflicts for pending work that goes on at the moment. 

Unfortunately, I forgot to replace this part when making the initial
release of the Devicescape stack. I've always used tabs myself, but some
of the areas of the code that I did not write was done using spaces.
Anyway, this should move to using tabs over time whenever source code is
being modified.

-- 
Jouni MalinenPGP id EFC895FA
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/8] d80211/bcm43xx: Modify struct ieee80211_rx_status for wireless statistics.

2006-08-08 Thread Larry Finger 

Part 1 of 8 to add wireless statistics to the bcm43xx-d80211 system. This patch 
adds new variables
to struct ieee80211_rx_status to contain the latest values for signal, noise, 
and the maximum value
of the received ssi. These could be u8's, but I left them as integers in case 
other drivers needed
larger values.

The patch is for the August 8 version of Linville's wireless-dev tree.

Signed-Off-By: Larry Finger [EMAIL PROTECTED]




diff --git a/include/net/d80211.h b/include/net/d80211.h
index ba5cb4c..8479b58 100644
--- a/include/net/d80211.h
+++ b/include/net/d80211.h
@@ -205,6 +205,9 @@ struct ieee80211_rx_status {
 int channel;
 int phymode;
 int ssi;
+   int maxssi;
+   int signal;
+   int noise;
 int antenna;
 int rate;
 int flag;


-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html