Re: [PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

2017-10-03 Thread David Miller 
From: Dan Carpenter 
Date: Tue, 3 Oct 2017 13:53:41 +0300

> We accidentally return success if the kmalloc_array() call fails.
> 
> Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware 
> logic")
> Signed-off-by: Dan Carpenter 

Applied.

Re: [PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

2017-10-03 Thread Yotam Gigi 
On 10/03/2017 01:53 PM, Dan Carpenter wrote:
> We accidentally return success if the kmalloc_array() call fails.
>
> Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware 
> logic")
> Signed-off-by: Dan Carpenter 

Acked-by: Yotam Gigi 

>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c 
> b/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
> index 5e4ccbf17e3d..839eadf0765b 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
> @@ -763,8 +763,10 @@ mlxsw_sp_mr_tcam_region_init(struct mlxsw_sp *mlxsw_sp,
>  
>   parman_prios = kmalloc_array(MLXSW_SP_MR_ROUTE_PRIO_MAX + 1,
>sizeof(*parman_prios), GFP_KERNEL);
> - if (!parman_prios)
> + if (!parman_prios) {
> + err = -ENOMEM;
>   goto err_parman_prios_alloc;
> + }
>   mr_tcam_region->parman_prios = parman_prios;
>  
>   for (i = 0; i < MLXSW_SP_MR_ROUTE_PRIO_MAX + 1; i++)

[PATCH 2/2 net-next] mlxsw: spectrum: Add missing error code on allocation failure

2017-10-03 Thread Dan Carpenter 
We accidentally return success if the kmalloc_array() call fails.

Fixes: 0e14cacb ("mlxsw: spectrum: Add the multicast routing hardware 
logic")
Signed-off-by: Dan Carpenter 

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c 
b/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
index 5e4ccbf17e3d..839eadf0765b 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_mr_tcam.c
@@ -763,8 +763,10 @@ mlxsw_sp_mr_tcam_region_init(struct mlxsw_sp *mlxsw_sp,
 
parman_prios = kmalloc_array(MLXSW_SP_MR_ROUTE_PRIO_MAX + 1,
 sizeof(*parman_prios), GFP_KERNEL);
-   if (!parman_prios)
+   if (!parman_prios) {
+   err = -ENOMEM;
goto err_parman_prios_alloc;
+   }
mr_tcam_region->parman_prios = parman_prios;
 
for (i = 0; i < MLXSW_SP_MR_ROUTE_PRIO_MAX + 1; i++)