Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.
Jeff Garzik wrote: Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ -struct ixgb_desc_ring tx_ring; +struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines... I guess cacheline_aligned_in_smp is preferred here. (see include/linux/netdevice.h) changed in our tree to cacheline_aligned_in_smp. Thanks, Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.
Jeff Garzik wrote: Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ -struct ixgb_desc_ring tx_ring; +struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines... I guess cacheline_aligned_in_smp is preferred here. (see include/linux/netdevice.h) Agreed. No objections. I can rework my tree if needed, but lets wait what else comes up first. Auke - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.
Eric Dumazet wrote: On Tuesday 29 August 2006 18:45, Kok, Auke wrote: /* TX */ - struct ixgb_desc_ring tx_ring; + struct ixgb_desc_ring tx_ring cacheline_aligned; unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines... I guess cacheline_aligned_in_smp is preferred here. (see include/linux/netdevice.h) Agreed. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.
On Tuesday 29 August 2006 18:45, Kok, Auke wrote: > > /* TX */ > - struct ixgb_desc_ring tx_ring; > + struct ixgb_desc_ring tx_ring cacheline_aligned; > unsigned long timeo_start; On UP, this would only enlarge the size of structure and might consume more cache lines... I guess cacheline_aligned_in_smp is preferred here. (see include/linux/netdevice.h) Eric - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 22/26] ixgb: Cache-align all TX components of the adapter struct.
Signed-off-by: Jesse Brandeburg <[EMAIL PROTECTED]>
Signed-off-by: Auke Kok <[EMAIL PROTECTED]>
---
drivers/net/ixgb/ixgb.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h
index a4bee8c..e157247 100644
--- a/drivers/net/ixgb/ixgb.h
+++ b/drivers/net/ixgb/ixgb.h
@@ -170,7 +170,7 @@ struct ixgb_adapter {
unsigned long led_status;
/* TX */
- struct ixgb_desc_ring tx_ring;
+ struct ixgb_desc_ring tx_ring cacheline_aligned;
unsigned long timeo_start;
uint32_t tx_cmd_type;
uint64_t hw_csum_tx_good;
---
Auke Kok <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
