Re: [PATCH 3/3] NetXen: Make driver use multi PCI functions

2007-03-05 Thread Mithlesh Thukral
On Saturday 03 March 2007 06:35, Jeff Garzik wrote:
 Linsys Contractor Mithlesh Thukral wrote:
  NetXen: Make driver use multi PCI functions.
 
  Signed-off by: Mithlesh Thukral [EMAIL PROTECTED]
 
  ---
 
   netxen_nic.h  |  126 +---
   netxen_nic_ethtool.c  |   80 +++
   netxen_nic_hdr.h  |8
   netxen_nic_hw.c   |  213 +++-
   netxen_nic_hw.h   |   18 -
   netxen_nic_init.c |  115 +++---
   netxen_nic_isr.c  |   80 +++
   netxen_nic_main.c |  523
  +- netxen_nic_niu.c 
  |   27 +-
   netxen_nic_phan_reg.h |  125 ---
   10 files changed, 631 insertions(+), 684 deletions(-)

 all three patches in this patchset contained nothing but one-line
 summaries of the changes included in them, and are overall very poorly
 and vaguely described.

 This patch is far too big, with far too little description and
 justification to go along with it.

 If you are not going to make the effort to write a paragraph or two
 describing such huge changes, then I'm not going to make the effort to
 review and apply it.  NAK.
My apologies for insufficient explanation of the patch. I have resend this 
patch some time ago. 

Regards,
Mithlesh Thukral
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH 3/3] NetXen: Make driver use multi PCI functions

2007-03-02 Thread Jeff Garzik

Linsys Contractor Mithlesh Thukral wrote:

NetXen: Make driver use multi PCI functions.

Signed-off by: Mithlesh Thukral [EMAIL PROTECTED]

---

 netxen_nic.h  |  126 +---
 netxen_nic_ethtool.c  |   80 +++
 netxen_nic_hdr.h  |8 
 netxen_nic_hw.c   |  213 +++-

 netxen_nic_hw.h   |   18 -
 netxen_nic_init.c |  115 +++---
 netxen_nic_isr.c  |   80 +++
 netxen_nic_main.c |  523 +-
 netxen_nic_niu.c  |   27 +-
 netxen_nic_phan_reg.h |  125 ---
 10 files changed, 631 insertions(+), 684 deletions(-)


all three patches in this patchset contained nothing but one-line 
summaries of the changes included in them, and are overall very poorly 
and vaguely described.


This patch is far too big, with far too little description and 
justification to go along with it.


If you are not going to make the effort to write a paragraph or two 
describing such huge changes, then I'm not going to make the effort to 
review and apply it.  NAK.



-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html