Re: [PATCH 3/6]: powerpc/cell spidernet stop error printing patch.
Am Saturday 30 September 2006 01:19 schrieb Linas Vepstas: Turn off mis-interpretation of the queue-empty interrupt status bit as an error. This bit is set as a part of the previous low-watermark patch. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Signed-off-by: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] Acked-by: Arnd Bergmann [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/6]: powerpc/cell spidernet stop error printing patch.
Turn off mis-interpretation of the queue-empty interrupt status bit as an error. This bit is set as a part of the previous low-watermark patch. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Signed-off-by: James K Lewis [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] drivers/net/spider_net.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index: linux-2.6.18-mm2/drivers/net/spider_net.c === --- linux-2.6.18-mm2.orig/drivers/net/spider_net.c 2006-09-29 15:01:55.0 -0500 +++ linux-2.6.18-mm2/drivers/net/spider_net.c 2006-09-29 16:33:43.0 -0500 @@ -1282,12 +1282,15 @@ spider_net_handle_error_irq(struct spide case SPIDER_NET_PHYINT: case SPIDER_NET_GMAC2INT: case SPIDER_NET_GMAC1INT: - case SPIDER_NET_GIPSINT: case SPIDER_NET_GFIFOINT: case SPIDER_NET_DMACINT: case SPIDER_NET_GSYSINT: break; */ + case SPIDER_NET_GIPSINT: + show_error = 0; + break; + case SPIDER_NET_GPWOPCMPINT: /* PHY write operation completed */ show_error = 0; @@ -1346,9 +1349,10 @@ spider_net_handle_error_irq(struct spide case SPIDER_NET_GDTDCEINT: /* chain end. If a descriptor should be sent, kick off * tx dma - if (card-tx_chain.tail == card-tx_chain.head) + if (card-tx_chain.tail != card-tx_chain.head) spider_net_kick_tx_dma(card); - show_error = 0; */ + */ + show_error = 0; break; /* case SPIDER_NET_G1TMCNTINT: not used. print a message */ @@ -1462,8 +1466,9 @@ spider_net_handle_error_irq(struct spide } if ((show_error) (netif_msg_intr(card))) - pr_err(Got error interrupt, GHIINT0STS = 0x%08x, + pr_err(Got error interrupt on %s, GHIINT0STS = 0x%08x, GHIINT1STS = 0x%08x, GHIINT2STS = 0x%08x\n, + card-netdev-name, status_reg, error_reg1, error_reg2); /* clear interrupt sources */ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 3/6]: powerpc/cell spidernet stop error printing patch.
Turn off mis-interpretation of the queue-empty interrupt status bit as an error. This bit is set as a part of the previous low-watermark patch. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Signed-off-by: James K Lewis [EMAIL PROTECTED] Cc: Utz Bacher [EMAIL PROTECTED] Cc: Jens Osterkamp [EMAIL PROTECTED] Cc: Arnd Bergmann [EMAIL PROTECTED] drivers/net/spider_net.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index: linux-2.6.18-rc3-mm2/drivers/net/spider_net.c === --- linux-2.6.18-rc3-mm2.orig/drivers/net/spider_net.c 2006-08-11 11:23:24.0 -0500 +++ linux-2.6.18-rc3-mm2/drivers/net/spider_net.c 2006-08-11 11:34:16.0 -0500 @@ -1275,12 +1275,15 @@ spider_net_handle_error_irq(struct spide case SPIDER_NET_PHYINT: case SPIDER_NET_GMAC2INT: case SPIDER_NET_GMAC1INT: - case SPIDER_NET_GIPSINT: case SPIDER_NET_GFIFOINT: case SPIDER_NET_DMACINT: case SPIDER_NET_GSYSINT: break; */ + case SPIDER_NET_GIPSINT: + show_error = 0; + break; + case SPIDER_NET_GPWOPCMPINT: /* PHY write operation completed */ show_error = 0; @@ -1339,9 +1342,10 @@ spider_net_handle_error_irq(struct spide case SPIDER_NET_GDTDCEINT: /* chain end. If a descriptor should be sent, kick off * tx dma - if (card-tx_chain.tail == card-tx_chain.head) + if (card-tx_chain.tail != card-tx_chain.head) spider_net_kick_tx_dma(card); - show_error = 0; */ + */ + show_error = 0; break; /* case SPIDER_NET_G1TMCNTINT: not used. print a message */ @@ -1455,8 +1459,9 @@ spider_net_handle_error_irq(struct spide } if ((show_error) (netif_msg_intr(card))) - pr_err(Got error interrupt, GHIINT0STS = 0x%08x, + pr_err(Got error interrupt on %s, GHIINT0STS = 0x%08x, GHIINT1STS = 0x%08x, GHIINT2STS = 0x%08x\n, + card-netdev-name, status_reg, error_reg1, error_reg2); /* clear interrupt sources */ - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html