Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

[David Miller]

From: Wolfram Sang 
Date: Mon,  5 Feb 2018 21:10:01 +0100

> Due to a typo, the mask was destroyed by a comparison instead of a bit
> shift.
> 
> Signed-off-by: Wolfram Sang 

Applied and queued up for -stable, thanks.

Re: [PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

[Tom Lendacky]

On 2/5/2018 2:10 PM, Wolfram Sang wrote:
> Due to a typo, the mask was destroyed by a comparison instead of a bit
> shift.
> 
> Signed-off-by: Wolfram Sang 

Excellent find.

Acked-by: Tom Lendacky 

David, this should also be applied to the 4.14 and 4.15 stable releases.

Thanks,
Tom

> ---
> Only build tested. To be applied individually per subsystem.
> 
>  drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c 
> b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index 7a3ebfd236f5eb..100adee778dfd6 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data)
>  
>   reissue_mask = 1 << 0;
>   if (!pdata->per_channel_irq)
> - reissue_mask |= 0x < 4;
> + reissue_mask |= 0x << 4;
>  
>   XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask);
>   }
> 

[PATCH 4/4] net: amd-xgbe: fix comparison to bitshift when dealing with a mask

[Wolfram Sang]

Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.

Signed-off-by: Wolfram Sang 
---
Only build tested. To be applied individually per subsystem.

 drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c 
b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
index 7a3ebfd236f5eb..100adee778dfd6 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
@@ -595,7 +595,7 @@ static void xgbe_isr_task(unsigned long data)
 
reissue_mask = 1 << 0;
if (!pdata->per_channel_irq)
-   reissue_mask |= 0x < 4;
+   reissue_mask |= 0x << 4;
 
XP_IOWRITE(pdata, XP_INT_REISSUE_EN, reissue_mask);
}
-- 
2.11.0