[PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat

2008-01-12 Thread Ilpo Järvinen 
net/netfilter/xt_policy.c:
  policy_mt | -906
 1 function changed, 906 bytes removed, diff: -906

net/netfilter/xt_policy.c:
  match_xfrm_state | +427
 1 function changed, 427 bytes added, diff: +427

net/netfilter/xt_policy.o:
 2 functions changed, 427 bytes added, 906 bytes removed, diff: -479

Alternatively, this could be done by combining identical
parts of the match_policy_in/out()

Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
---
 net/netfilter/xt_policy.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/netfilter/xt_policy.c b/net/netfilter/xt_policy.c
index 46ee7e8..45731ca 100644
--- a/net/netfilter/xt_policy.c
+++ b/net/netfilter/xt_policy.c
@@ -33,7 +33,7 @@ xt_addr_cmp(const union xt_policy_addr *a1, const union 
xt_policy_addr *m,
return false;
 }
 
-static inline bool
+static bool
 match_xfrm_state(const struct xfrm_state *x, const struct xt_policy_elem *e,
 unsigned short family)
 {
-- 
1.5.0.6

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat

2008-01-12 Thread David Miller 
From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:27 +0200

Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.

Patrick, please review, thanks.

 net/netfilter/xt_policy.c:
   policy_mt | -906
  1 function changed, 906 bytes removed, diff: -906
 
 net/netfilter/xt_policy.c:
   match_xfrm_state | +427
  1 function changed, 427 bytes added, diff: +427
 
 net/netfilter/xt_policy.o:
  2 functions changed, 427 bytes added, 906 bytes removed, diff: -479
 
 Alternatively, this could be done by combining identical
 parts of the match_policy_in/out()
 
 Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED]
 ---
  net/netfilter/xt_policy.c |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/net/netfilter/xt_policy.c b/net/netfilter/xt_policy.c
 index 46ee7e8..45731ca 100644
 --- a/net/netfilter/xt_policy.c
 +++ b/net/netfilter/xt_policy.c
 @@ -33,7 +33,7 @@ xt_addr_cmp(const union xt_policy_addr *a1, const union 
 xt_policy_addr *m,
   return false;
  }
  
 -static inline bool
 +static bool
  match_xfrm_state(const struct xfrm_state *x, const struct xt_policy_elem *e,
unsigned short family)
  {
 -- 
 1.5.0.6
 
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat

2008-01-12 Thread Patrick McHardy 

David Miller wrote:

From: Ilpo_Järvinen [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 11:34:27 +0200

Ilpo, please post netfilter patches to netfilter-devel,
CC:'ing Patrick McHardy.

Patrick, please review, thanks.


This looks fine to me, thanks Ilpo.


net/netfilter/xt_policy.c:
  policy_mt | -906
 1 function changed, 906 bytes removed, diff: -906

net/netfilter/xt_policy.c:
  match_xfrm_state | +427
 1 function changed, 427 bytes added, diff: +427

net/netfilter/xt_policy.o:
 2 functions changed, 427 bytes added, 906 bytes removed, diff: -479

Alternatively, this could be done by combining identical
parts of the match_policy_in/out()


That would probably end up rather ugly because they walk
over different structures and have some minor differences.

--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 6/8] [NETFILTER] xt_policy.c: kill some bloat

2008-01-12 Thread David Miller 
From: Patrick McHardy [EMAIL PROTECTED]
Date: Sat, 12 Jan 2008 20:03:31 +0100

 David Miller wrote:
  From: Ilpo_Järvinen [EMAIL PROTECTED]
  Date: Sat, 12 Jan 2008 11:34:27 +0200
  
  Ilpo, please post netfilter patches to netfilter-devel,
  CC:'ing Patrick McHardy.
  
  Patrick, please review, thanks.
 
 This looks fine to me, thanks Ilpo.

Applied, thanks.
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html