Re: [PATCH RFC 24/28] net: dsa: If a switch fails to probe, defer probing

[Florian Fainelli]

Le 23/12/2015 04:56, Andrew Lunn a écrit :
> Switches are either listed in device tree of platform_data. They
> should exist. If the probe fails, defer the probe, which is the likely
> cause of failure, not broken device tree or platform data.
> 
> Signed-off-by: Andrew Lunn 

Acked-by: Florian Fainelli 
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH RFC 24/28] net: dsa: If a switch fails to probe, defer probing

[Andrew Lunn]

Switches are either listed in device tree of platform_data. They
should exist. If the probe fails, defer the probe, which is the likely
cause of failure, not broken device tree or platform data.

Signed-off-by: Andrew Lunn 
---
 net/dsa/dsa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 5e037772bb32..c5f55b672675 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -391,7 +391,7 @@ dsa_switch_setup(struct dsa_switch_tree *dst, int index,
if (drv == NULL) {
netdev_err(dst->master_netdev, "[%d]: could not detect attached 
switch\n",
   index);
-   return ERR_PTR(-EINVAL);
+   return ERR_PTR(-EPROBE_DEFER);
}
netdev_info(dst->master_netdev, "[%d]: detected a %s switch\n",
index, name);
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html