Re: [PATCH bpf-next] selftests/bpf: fix return value comparison for tests in test_libbpf.sh

[Alexei Starovoitov]

On Sat, Oct 20, 2018 at 10:58:44PM +0100, Quentin Monnet wrote:
> The return value for each test in test_libbpf.sh is compared with
> 
> if (( $? == 0 )) ; then ...
> 
> This works well with bash, but not with dash, that /bin/sh is aliased to
> on some systems (such as Ubuntu).
> 
> Let's replace this comparison by something that works on both shells.
> 
> Signed-off-by: Quentin Monnet 
> Reviewed-by: Jakub Kicinski 

Applied, Thanks

[PATCH bpf-next] selftests/bpf: fix return value comparison for tests in test_libbpf.sh

[Quentin Monnet]

The return value for each test in test_libbpf.sh is compared with

if (( $? == 0 )) ; then ...

This works well with bash, but not with dash, that /bin/sh is aliased to
on some systems (such as Ubuntu).

Let's replace this comparison by something that works on both shells.

Signed-off-by: Quentin Monnet 
Reviewed-by: Jakub Kicinski 
---
 tools/testing/selftests/bpf/test_libbpf.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_libbpf.sh 
b/tools/testing/selftests/bpf/test_libbpf.sh
index d97dc914cd49..156d89f1edcc 100755
--- a/tools/testing/selftests/bpf/test_libbpf.sh
+++ b/tools/testing/selftests/bpf/test_libbpf.sh
@@ -6,7 +6,7 @@ export TESTNAME=test_libbpf
 # Determine selftest success via shell exit code
 exit_handler()
 {
-   if (( $? == 0 )); then
+   if [ $? -eq 0 ]; then
echo "selftests: $TESTNAME [PASS]";
else
echo "$TESTNAME: failed at file $LAST_LOADED" 1>&2
-- 
2.7.4