Re: [PATCH bpf-next 0/3] bpf: add bpffs pretty print for hash/lru_hash maps

[Daniel Borkmann]

On 08/09/2018 05:55 PM, Yonghong Song wrote:
> Commit a26ca7c982cb ("bpf: btf: Add pretty print support to
> the basic arraymap") added pretty print support to array map.
> This patch adds pretty print for hash and lru_hash maps.
> 
> The following example shows the pretty-print result of a pinned hashmap.
> Without this patch set, user will get an error instead.
> 
> struct map_value {
> int count_a;
> int count_b;
> };
> 
> cat /sys/fs/bpf/pinned_hash_map:
> 
> 87907: {87907,87908}
> 57354: {37354,57355}
> 76625: {76625,76626}
> ...
> 
> Patch #1 fixed a bug in bpffs map_seq_next() function so that
> all elements in the hash table will be traversed.
> Patch #2 implemented map_seq_show_elem() and map_check_btf()
> callback functions for hash and lru hash maps.
> Patch #3 enhanced tools/testing/selftests/bpf/test_btf.c to
> test bpffs hash and lru hash map pretty print.
> 
> Yonghong Song (3):
>   bpf: fix bpffs non-array map seq_show issue
>   bpf: btf: add pretty print for hash/lru_hash maps
>   tools/bpf: add bpffs pretty print btf test for hash/lru_hash maps
> 
>  kernel/bpf/hashtab.c   | 44 +
>  kernel/bpf/inode.c |  8 ++--
>  tools/testing/selftests/bpf/test_btf.c | 87 
> --
>  3 files changed, 121 insertions(+), 18 deletions(-)

Applied to bpf-next, thanks Yonghong!

[PATCH bpf-next 0/3] bpf: add bpffs pretty print for hash/lru_hash maps

[Yonghong Song]

Commit a26ca7c982cb ("bpf: btf: Add pretty print support to
the basic arraymap") added pretty print support to array map.
This patch adds pretty print for hash and lru_hash maps.

The following example shows the pretty-print result of a pinned hashmap.
Without this patch set, user will get an error instead.

struct map_value {
int count_a;
int count_b;
};

cat /sys/fs/bpf/pinned_hash_map:

87907: {87907,87908}
57354: {37354,57355}
76625: {76625,76626}
...

Patch #1 fixed a bug in bpffs map_seq_next() function so that
all elements in the hash table will be traversed.
Patch #2 implemented map_seq_show_elem() and map_check_btf()
callback functions for hash and lru hash maps.
Patch #3 enhanced tools/testing/selftests/bpf/test_btf.c to
test bpffs hash and lru hash map pretty print.

Yonghong Song (3):
  bpf: fix bpffs non-array map seq_show issue
  bpf: btf: add pretty print for hash/lru_hash maps
  tools/bpf: add bpffs pretty print btf test for hash/lru_hash maps

 kernel/bpf/hashtab.c   | 44 +
 kernel/bpf/inode.c |  8 ++--
 tools/testing/selftests/bpf/test_btf.c | 87 --
 3 files changed, 121 insertions(+), 18 deletions(-)

-- 
2.14.3