Re: [PATCH bpf-next v3 0/9] bpf: offload: report device back to user space (take 2)
On 12/28/2017 03:39 AM, Jakub Kicinski wrote: > Hi! > > This series is a redo of reporting offload device information to > user space after the first attempt did not take into account name > spaces. As requested by Kirill offloads are now protected by an > r/w sem. This allows us to remove the workqueue and free the > offload state fully when device is removed (suggested by Alexei). > > Net namespace is reported with a device/inode pair. > > The accompanying bpftool support is placed in common code because > maps will have very similar info. Note that the UAPI information > can't be nicely encapsulated into a struct, because in case we > need to grow the device information the new fields will have to > be added at the end of struct bpf_prog_info, we can't grow > structures in the middle of bpf_prog_info. > > v3: > - use dev_get_by_index(); > - redo ns code (new patch 6). > v2: > - rework the locking in patch 1 (use RCU instead of locking >dependencies); > - grab RTNL for a short time in patch 6; > - minor update to the test in patch 8. Series applied to bpf-next, thanks Jakub!
[PATCH bpf-next v3 0/9] bpf: offload: report device back to user space (take 2)
Hi! This series is a redo of reporting offload device information to user space after the first attempt did not take into account name spaces. As requested by Kirill offloads are now protected by an r/w sem. This allows us to remove the workqueue and free the offload state fully when device is removed (suggested by Alexei). Net namespace is reported with a device/inode pair. The accompanying bpftool support is placed in common code because maps will have very similar info. Note that the UAPI information can't be nicely encapsulated into a struct, because in case we need to grow the device information the new fields will have to be added at the end of struct bpf_prog_info, we can't grow structures in the middle of bpf_prog_info. v3: - use dev_get_by_index(); - redo ns code (new patch 6). v2: - rework the locking in patch 1 (use RCU instead of locking dependencies); - grab RTNL for a short time in patch 6; - minor update to the test in patch 8. Jakub Kicinski (9): bpf: offload: don't require rtnl for dev list manipulation bpf: offload: don't use prog->aux->offload as boolean bpf: offload: allow netdev to disappear while verifier is running bpf: offload: free prog->aux->offload when device disappears bpf: offload: free program id when device disappears nsfs: generalize ns_get_path() for path resolution with a task bpf: offload: report device information for offloaded programs tools: bpftool: report device information for offloaded programs selftests/bpf: test device info reporting for bound progs drivers/net/ethernet/netronome/nfp/bpf/main.h | 2 +- drivers/net/ethernet/netronome/nfp/bpf/verifier.c | 2 +- drivers/net/netdevsim/bpf.c | 2 +- fs/nsfs.c | 29 - include/linux/bpf.h | 16 ++- include/linux/bpf_verifier.h | 16 +-- include/linux/netdevice.h | 4 +- include/linux/proc_ns.h | 3 + include/uapi/linux/bpf.h | 3 + kernel/bpf/offload.c | 147 -- kernel/bpf/syscall.c | 19 ++- kernel/bpf/verifier.c | 20 ++- tools/bpf/bpftool/common.c| 52 tools/bpf/bpftool/main.h | 2 + tools/bpf/bpftool/prog.c | 3 + tools/include/uapi/linux/bpf.h| 3 + tools/testing/selftests/bpf/test_offload.py | 112 +++-- 17 files changed, 346 insertions(+), 89 deletions(-) -- 2.15.1
