Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-22 Thread Stephen Hemminger 
On Thu, 18 Aug 2016 15:14:38 -0700
Eric Dumazet  wrote:

> On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
> > On Wed, 17 Aug 2016 14:39:21 -0700
> > Eric Dumazet  wrote:
> >   
> > > From: Eric Dumazet 
> > > 
> > > kernel support for these attributes was added in linux-4.6
> > > 
> > > Signed-off-by: Eric Dumazet   
> > 
> > 
> > What about setting them?  
> 
> This is not something the kernel does at this moment.
> 
> Drivers usually set a value, depending on hardware or software
> constraints.
> 
> 
> 

Ok, applied.

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-18 Thread Stephen Hemminger 
On Wed, 17 Aug 2016 14:39:21 -0700
Eric Dumazet  wrote:

> From: Eric Dumazet 
> 
> kernel support for these attributes was added in linux-4.6
> 
> Signed-off-by: Eric Dumazet 


What about setting them?

Re: [PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-18 Thread Eric Dumazet 
On Thu, 2016-08-18 at 14:52 -0700, Stephen Hemminger wrote:
> On Wed, 17 Aug 2016 14:39:21 -0700
> Eric Dumazet  wrote:
> 
> > From: Eric Dumazet 
> > 
> > kernel support for these attributes was added in linux-4.6
> > 
> > Signed-off-by: Eric Dumazet 
> 
> 
> What about setting them?

This is not something the kernel does at this moment.

Drivers usually set a value, depending on hardware or software
constraints.

[PATCH iproute2] ip: report IFLA_GSO_MAX_SIZE and IFLA_GSO_MAX_SEGS

2016-08-17 Thread Eric Dumazet 
From: Eric Dumazet 

kernel support for these attributes was added in linux-4.6

Signed-off-by: Eric Dumazet 
---
 ip/ipaddress.c |8 
 1 file changed, 8 insertions(+)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index ab4b1b1..76bd7b3 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -901,6 +901,14 @@ int print_linkinfo(const struct sockaddr_nl *who,
fprintf(fp, "numrxqueues %u ",
rta_getattr_u32(tb[IFLA_NUM_RX_QUEUES]));
 
+   if (tb[IFLA_GSO_MAX_SIZE])
+   fprintf(fp, "gso_max_size %u ",
+   rta_getattr_u32(tb[IFLA_GSO_MAX_SIZE]));
+
+   if (tb[IFLA_GSO_MAX_SEGS])
+   fprintf(fp, "gso_max_segs %u ",
+   rta_getattr_u32(tb[IFLA_GSO_MAX_SEGS]));
+
if (tb[IFLA_PHYS_PORT_NAME])
fprintf(fp, "portname %s ",
rta_getattr_str(tb[IFLA_PHYS_PORT_NAME]));