Re: [PATCH net] bnxt_en: Fix TX push operation on ARM64.

2016-09-06 Thread David Miller
From: Michael Chan 
Date: Mon,  5 Sep 2016 01:57:35 -0400

> There is a code path where we are calling __iowrite64_copy() on
> an address that is not 64-bit aligned.  This causes an exception on
> some architectures such as arm64.  Fix that code path by using
> __iowrite32_copy().
> 
> Reported-by: JD Zheng 
> Signed-off-by: Michael Chan 

Applied and queued up for -stable, thanks.


[PATCH net] bnxt_en: Fix TX push operation on ARM64.

2016-09-04 Thread Michael Chan
There is a code path where we are calling __iowrite64_copy() on
an address that is not 64-bit aligned.  This causes an exception on
some architectures such as arm64.  Fix that code path by using
__iowrite32_copy().

Reported-by: JD Zheng 
Signed-off-by: Michael Chan 
---

Please consider this for stable as well.  Thanks.

 drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c 
b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 2cf7910..228c964 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -353,8 +353,8 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, 
struct net_device *dev)
push_len = (length + sizeof(*tx_push) + 7) / 8;
if (push_len > 16) {
__iowrite64_copy(txr->tx_doorbell, tx_push_buf, 16);
-   __iowrite64_copy(txr->tx_doorbell + 4, tx_push_buf + 1,
-push_len - 16);
+   __iowrite32_copy(txr->tx_doorbell + 4, tx_push_buf + 1,
+(push_len - 16) << 1);
} else {
__iowrite64_copy(txr->tx_doorbell, tx_push_buf,
 push_len);
-- 
1.8.3.1