Re: [PATCH net] cxgb4: Added missing break in ndo_udp_tunnel_{add/del}

[David Miller]

From: Arjun Vynipadath 
Date: Wed, 25 Jul 2018 19:39:52 +0530

> Break statements were missing for Geneve case in
> ndo_udp_tunnel_{add/del}, thereby raw mac matchall
> entries were not getting added.
> 
> Fixes: c746fc0e8b2d("cxgb4: add geneve offload support for T6")
> Signed-off-by: Arjun Vynipadath 
> Signed-off-by: Ganesh Goudar 

Applied and queued up for -stable.

[PATCH net] cxgb4: Added missing break in ndo_udp_tunnel_{add/del}

[Arjun Vynipadath]

Break statements were missing for Geneve case in
ndo_udp_tunnel_{add/del}, thereby raw mac matchall
entries were not getting added.

Fixes: c746fc0e8b2d("cxgb4: add geneve offload support for T6")
Signed-off-by: Arjun Vynipadath 
Signed-off-by: Ganesh Goudar 
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c 
b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 40cf8dc..a46a010 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -3074,6 +3074,7 @@ static void cxgb_del_udp_tunnel(struct net_device *netdev,
 
adapter->geneve_port = 0;
t4_write_reg(adapter, MPS_RX_GENEVE_TYPE_A, 0);
+   break;
default:
return;
}
@@ -3159,6 +3160,7 @@ static void cxgb_add_udp_tunnel(struct net_device *netdev,
 
t4_write_reg(adapter, MPS_RX_GENEVE_TYPE_A,
 GENEVE_V(be16_to_cpu(ti->port)) | GENEVE_EN_F);
+   break;
default:
return;
}
-- 
2.3.5