Re: [PATCH net] net: bcmgenet: device stats are unsigned long

[Florian Fainelli]

Le 15/04/2016 10:47, Eric Dumazet a écrit :
> From: Eric Dumazet 
> 
> On 64bit kernels, device stats are 64bit wide, not 32bit.
> 
> Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file")
> Signed-off-by: Eric Dumazet 
> Cc: Florian Fainelli 

Late, but:

Acked-by: Florian Fainelli 

Thanks Eric!
-- 
Florian

Re: [PATCH net] net: bcmgenet: device stats are unsigned long

[David Miller]

From: Eric Dumazet 
Date: Fri, 15 Apr 2016 10:47:52 -0700

> From: Eric Dumazet 
> 
> On 64bit kernels, device stats are 64bit wide, not 32bit.
> 
> Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file")
> Signed-off-by: Eric Dumazet 
> Cc: Florian Fainelli 

Applied, thanks Eric.

[PATCH net] net: bcmgenet: device stats are unsigned long

[Eric Dumazet]

From: Eric Dumazet 

On 64bit kernels, device stats are 64bit wide, not 32bit.

Fixes: 1c1008c793fa4 ("net: bcmgenet: add main driver file")
Signed-off-by: Eric Dumazet 
Cc: Florian Fainelli 
---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c |6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c 
b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index cf6445d148ca..44ad1490b472 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -878,7 +878,11 @@ static void bcmgenet_get_ethtool_stats(struct net_device 
*dev,
else
p = (char *)priv;
p += s->stat_offset;
-   data[i] = *(u32 *)p;
+   if (sizeof(unsigned long) != sizeof(u32) &&
+   s->stat_sizeof == sizeof(unsigned long))
+   data[i] = *(unsigned long *)p;
+   else
+   data[i] = *(u32 *)p;
}
 }