Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-21 Thread David Miller 
From: Nathan Fontenot 
Date: Wed, 21 Jun 2017 14:48:06 -0500

> On 06/21/2017 02:39 PM, David Miller wrote:
>> From: Nathan Fontenot 
>> Date: Tue, 20 Jun 2017 17:21:54 -0400
>> 
>>> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
>> 
>> I'm incredibly curious where you got the idea to put the Fixes: tag
>> at the beginning of the commit message.
> 
> I have no excuse. As you mentioned I should have looked at what others
> had done when using the Fixes.
> 
> Would you like me to re-send with the Fixes tag corrected?

Yes, please.

Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-21 Thread Nathan Fontenot 
On 06/21/2017 02:39 PM, David Miller wrote:
> From: Nathan Fontenot 
> Date: Tue, 20 Jun 2017 17:21:54 -0400
> 
>> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)
> 
> I'm incredibly curious where you got the idea to put the Fixes: tag
> at the beginning of the commit message.

I have no excuse. As you mentioned I should have looked at what others
had done when using the Fixes.

Would you like me to re-send with the Fixes tag corrected?

-Nathan

> 
> Have you seen anyone else submitting patches on netdev do this?
> 
> It helps to operate by example, and look at how other people do
> things.
> 
> The correct location for the Fixes: tag is at the beginning of the
> singoffs and acks at the end of the commit message.
> 
> There shall be no empty lines between the Fixes: tag and those
> signoffs and acks.
> 
> Thank you.
>

Re: [PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-21 Thread David Miller 
From: Nathan Fontenot 
Date: Tue, 20 Jun 2017 17:21:54 -0400

> Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)

I'm incredibly curious where you got the idea to put the Fixes: tag
at the beginning of the commit message.

Have you seen anyone else submitting patches on netdev do this?

It helps to operate by example, and look at how other people do
things.

The correct location for the Fixes: tag is at the beginning of the
singoffs and acks at the end of the commit message.

There shall be no empty lines between the Fixes: tag and those
signoffs and acks.

Thank you.

[PATCH net-next] ibmvnic: Correct return code checking for ibmvnic_init during probe

2017-06-20 Thread Nathan Fontenot 
Fixes: 6a2fb0e99f9c (ibmvnic: driver initialization for kdump/kexec)

The update to ibmvnic_init to allow an EAGAIN return code broke
the calling of ibmvnic_init from ibmvnic_probe. The code now
will return from this point in the probe routine if anything
other than EAGAIN is returned. The check should be to see if rc
is non-zero and not equal to EAGAIN.

Without this fix, the vNIC driver can return 0 (success) from
its probe routine due to ibmvnic_init returning zero, but before
completing the probe process and registering with the netdev layer.

Signed-off-by: Nathan Fontenot 
---
 drivers/net/ethernet/ibm/ibmvnic.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c 
b/drivers/net/ethernet/ibm/ibmvnic.c
index 722daf5..4e17217 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -3737,7 +3737,7 @@ static int ibmvnic_probe(struct vio_dev *dev, const 
struct vio_device_id *id)
 
do {
rc = ibmvnic_init(adapter);
-   if (rc != EAGAIN) {
+   if (rc && rc != EAGAIN) {
free_netdev(netdev);
return rc;
}