Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute

[David Miller]

From: David Ahern 
Date: Thu, 26 Jan 2017 14:08:36 -0800

> Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
> allocated skb is not passed through the routing engine (like it is for
> IPv4) and has not since the beginning of git time.
> 
> Signed-off-by: David Ahern 

Good catch, applied, thanks David.

Re: [PATCH net-next] net: ipv6: remove skb_reserve in getroute

[Eric Dumazet]

On Thu, 2017-01-26 at 14:08 -0800, David Ahern wrote:
> Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
> allocated skb is not passed through the routing engine (like it is for
> IPv4) and has not since the beginning of git time.
> 
> Signed-off-by: David Ahern 
> ---
>  net/ipv6/route.c | 6 --
>  1 file changed, 6 deletions(-)

Nice ;)

Acked-by: Eric Dumazet 

[PATCH net-next] net: ipv6: remove skb_reserve in getroute

[David Ahern]

Remove skb_reserve and skb_reset_mac_header from inet6_rtm_getroute. The
allocated skb is not passed through the routing engine (like it is for
IPv4) and has not since the beginning of git time.

Signed-off-by: David Ahern 
---
 net/ipv6/route.c | 6 --
 1 file changed, 6 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 47499ed429da..5046d2b24004 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -3420,12 +3420,6 @@ static int inet6_rtm_getroute(struct sk_buff *in_skb, 
struct nlmsghdr *nlh)
goto errout;
}
 
-   /* Reserve room for dummy headers, this skb can pass
-  through good chunk of routing engine.
-*/
-   skb_reset_mac_header(skb);
-   skb_reserve(skb, MAX_HEADER + sizeof(struct ipv6hdr));
-
skb_dst_set(skb, >dst);
 
err = rt6_fill_node(net, skb, rt, , , iif,
-- 
2.1.4