Re: [PATCH net-next v2] bonding: deliver link-local packets with skb->dev set to link that packets arrived on
From: Chonggang LiDate: Sun, 16 Apr 2017 12:02:18 -0700 > Bonding driver changes the skb->dev to the bonding-master before > passing the packet to stack for further processing. This, however > does not make sense for the link-local packets and it looses "the > link info" once its skb->dev is changed to bonding-master. This > patch changes this behavior for link-local packets by not changing > the skb->dev to the bonding-master and maintaining it as it is, > i.e. the link on which the packet arrived. > > Signed-off-by: Chonggang Li > Signed-off-by: Mahesh Bandewar > Signed-off-by: Maciej Żenczykowski > --- > Changes in v2: > - Make the commit message more clearer. Applied with "looses" type fixed.
Re: [PATCH net-next v2] bonding: deliver link-local packets with skb->dev set to link that packets arrived on
Chonggang Liwrote: >Bonding driver changes the skb->dev to the bonding-master before >passing the packet to stack for further processing. This, however >does not make sense for the link-local packets and it looses "the >link info" once its skb->dev is changed to bonding-master. This >patch changes this behavior for link-local packets by not changing >the skb->dev to the bonding-master and maintaining it as it is, >i.e. the link on which the packet arrived. Minor nit: "looses" should be "loses". Other than that: Signed-off-by: Jay Vosburgh >Signed-off-by: Chonggang Li >Signed-off-by: Mahesh Bandewar >Signed-off-by: Maciej Żenczykowski >--- >Changes in v2: > - Make the commit message more clearer. > > drivers/net/bonding/bond_main.c | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index 01e4a69af421..6bd3b50faf48 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -1176,6 +1176,9 @@ static rx_handler_result_t bond_handle_frame(struct >sk_buff **pskb) > } > } > >+ /* don't change skb->dev for link-local packets */ >+ if (is_link_local_ether_addr(eth_hdr(skb)->h_dest)) >+ return RX_HANDLER_PASS; > if (bond_should_deliver_exact_match(skb, slave, bond)) > return RX_HANDLER_EXACT; > >-- >2.12.2.762.g0e3151a226-goog >
[PATCH net-next v2] bonding: deliver link-local packets with skb->dev set to link that packets arrived on
Bonding driver changes the skb->dev to the bonding-master before passing the packet to stack for further processing. This, however does not make sense for the link-local packets and it looses "the link info" once its skb->dev is changed to bonding-master. This patch changes this behavior for link-local packets by not changing the skb->dev to the bonding-master and maintaining it as it is, i.e. the link on which the packet arrived. Signed-off-by: Chonggang LiSigned-off-by: Mahesh Bandewar Signed-off-by: Maciej Żenczykowski --- Changes in v2: - Make the commit message more clearer. drivers/net/bonding/bond_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 01e4a69af421..6bd3b50faf48 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1176,6 +1176,9 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb) } } + /* don't change skb->dev for link-local packets */ + if (is_link_local_ether_addr(eth_hdr(skb)->h_dest)) + return RX_HANDLER_PASS; if (bond_should_deliver_exact_match(skb, slave, bond)) return RX_HANDLER_EXACT; -- 2.12.2.762.g0e3151a226-goog