Re: [PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

[Nikolay Aleksandrov]

On 28/02/18 05:52, Roopa Prabhu wrote:
> From: Roopa Prabhu 
> 
> support to match on src port, dst port and ip protocol.
> 
> Signed-off-by: Roopa Prabhu 
> ---
>  net/ipv4/fib_rules.c | 11 +++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
> index 35d646a..16083b8 100644
> --- a/net/ipv4/fib_rules.c
> +++ b/net/ipv4/fib_rules.c
> @@ -182,6 +182,17 @@ static int fib4_rule_match(struct fib_rule *rule, struct 
> flowi *fl, int flags)
>   if (r->tos && (r->tos != fl4->flowi4_tos))
>   return 0;
>  
> + if (rule->ip_proto && (rule->ip_proto != fl4->flowi4_proto))
> + return 0;
> +
> + if (fib_rule_port_range_set(>sport_range) &&
> + !fib_rule_port_inrange(>sport_range, fl4->fl4_sport))
> + return 0;
> +
> + if (fib_rule_port_range_set(>dport_range) &&
> + !fib_rule_port_inrange(>dport_range, fl4->fl4_dport))
> + return 0;
> +
>   return 1;
>  }
>  
> 

Acked-by: Nikolay Aleksandrov 

[PATCH net-next v2 2/5] ipv4: fib_rules: support match on sport, dport and ip proto

[Roopa Prabhu]

From: Roopa Prabhu 

support to match on src port, dst port and ip protocol.

Signed-off-by: Roopa Prabhu 
---
 net/ipv4/fib_rules.c | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/net/ipv4/fib_rules.c b/net/ipv4/fib_rules.c
index 35d646a..16083b8 100644
--- a/net/ipv4/fib_rules.c
+++ b/net/ipv4/fib_rules.c
@@ -182,6 +182,17 @@ static int fib4_rule_match(struct fib_rule *rule, struct 
flowi *fl, int flags)
if (r->tos && (r->tos != fl4->flowi4_tos))
return 0;
 
+   if (rule->ip_proto && (rule->ip_proto != fl4->flowi4_proto))
+   return 0;
+
+   if (fib_rule_port_range_set(>sport_range) &&
+   !fib_rule_port_inrange(>sport_range, fl4->fl4_sport))
+   return 0;
+
+   if (fib_rule_port_range_set(>dport_range) &&
+   !fib_rule_port_inrange(>dport_range, fl4->fl4_dport))
+   return 0;
+
return 1;
 }
 
-- 
2.1.4