Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback
Please do not top post. My fault. Will be more careful in future. No problem here. I do not see obvious reasons for breaking your setup. It was a problem with my network driver not getting installed due to some symbol mismatch after a compile. It got sorted out after I cleaned up everything. This was a false alarm. Apologies for the noise. Vijay -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback
On Wed, 2015-05-20 at 11:13 -0700, Vijay Subramanian wrote: Hi Daniel, With this commit, ifconfig does not show any of the interfaces and I don't have any connectivity as a result. Can you double check this? Please do not top post. No problem here. I do not see obvious reasons for breaking your setup. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback
Hi Daniel, With this commit, ifconfig does not show any of the interfaces and I don't have any connectivity as a result. Can you double check this? Thanks! Vijay On 19 May 2015 at 13:54, David Miller da...@davemloft.net wrote: From: Daniel Borkmann dan...@iogearbox.net Date: Tue, 19 May 2015 21:33:42 +0200 This work as a follow-up of commit f7b3bec6f516 (net: allow setting ecn via routing table) and adds RFC3168 section 6.1.1.1. fallback for outgoing ECN connections. In other words, this work adds a retry with a non-ECN setup SYN packet, as suggested from the RFC on the first timeout: [...] A host that receives no reply to an ECN-setup SYN within the normal SYN retransmission timeout interval MAY resend the SYN and any subsequent SYN retransmissions with CWR and ECE cleared. [...] ... Reference: https://www.ietf.org/proceedings/92/slides/slides-92-iccrg-1.pdf Reference: https://www.ietf.org/proceedings/89/slides/slides-89-tsvarea-1.pdf Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Mirja Kühlewind mirja.kuehlew...@tik.ee.ethz.ch Signed-off-by: Brian Trammell tramm...@tik.ee.ethz.ch Cc: Eric Dumazet eduma...@google.com Cc: Dave Täht dave.t...@gmail.com --- v2 - v3: - Very sorry. Typo happened in Dave's name since v1, getting it right this time, no bad intentions. ;) v1 - v2: - Added suggestion from Eric to let ecn_flags be cleared eventually in tcp_ecn_rcv_synack(), thanks! - Rest as is. Applied, thanks everyone. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH net-next v3] tcp: add rfc3168, section 6.1.1.1. fallback
From: Daniel Borkmann dan...@iogearbox.net Date: Tue, 19 May 2015 21:33:42 +0200 This work as a follow-up of commit f7b3bec6f516 (net: allow setting ecn via routing table) and adds RFC3168 section 6.1.1.1. fallback for outgoing ECN connections. In other words, this work adds a retry with a non-ECN setup SYN packet, as suggested from the RFC on the first timeout: [...] A host that receives no reply to an ECN-setup SYN within the normal SYN retransmission timeout interval MAY resend the SYN and any subsequent SYN retransmissions with CWR and ECE cleared. [...] ... Reference: https://www.ietf.org/proceedings/92/slides/slides-92-iccrg-1.pdf Reference: https://www.ietf.org/proceedings/89/slides/slides-89-tsvarea-1.pdf Signed-off-by: Daniel Borkmann dan...@iogearbox.net Signed-off-by: Florian Westphal f...@strlen.de Signed-off-by: Mirja Kühlewind mirja.kuehlew...@tik.ee.ethz.ch Signed-off-by: Brian Trammell tramm...@tik.ee.ethz.ch Cc: Eric Dumazet eduma...@google.com Cc: Dave Täht dave.t...@gmail.com --- v2 - v3: - Very sorry. Typo happened in Dave's name since v1, getting it right this time, no bad intentions. ;) v1 - v2: - Added suggestion from Eric to let ecn_flags be cleared eventually in tcp_ecn_rcv_synack(), thanks! - Rest as is. Applied, thanks everyone. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
